Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enum return value size. #987

Merged
merged 1 commit into from
Jan 7, 2023
Merged

Fix enum return value size. #987

merged 1 commit into from
Jan 7, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 6, 2023

Fixes godotengine/godot#62935

On the engine side, enum values are always 64-bit, so use int64_t temporary return variable to avoid stack corruption.

@bruvzg bruvzg added bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation labels Jan 6, 2023
@bruvzg bruvzg added this to the 4.0 milestone Jan 6, 2023
@bruvzg bruvzg marked this pull request as ready for review January 7, 2023 09:11
@bruvzg bruvzg requested a review from a team as a code owner January 7, 2023 09:11
@bruvzg bruvzg mentioned this pull request Jan 7, 2023
Closed
@akien-mga akien-mga merged commit 2f785c9 into godotengine:master Jan 7, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

GDExtension: crash on get_mouse_mode()
2 participants
@bruvzg @akien-mga