Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ContentWithoutSummary #12778

Closed
bep opened this issue Aug 17, 2024 · 1 comment
Closed

Add ContentWithoutSummary #12778

bep opened this issue Aug 17, 2024 · 1 comment
Assignees
@bep
Labels
Enhancement Outdated
Milestone
v0.134.0

Comments

@bep
Copy link
Member

bep commented Aug 17, 2024 •
edited
Loading

For the manual split summaries, this is trivial.

For the auto split summaries (controlled by summaryLength config), this is not trivial. So I'm not sure what to do about that.

Since

  1. There's already a format discrepancy between the 2 (HTML vs plain text).
  2. The developer budget for this is very ... limited.

I'm tempted to change the auto logic so it becomes: Summary is the first n paragraphs (e.g. <p>) >= summaryLength words. I will preserve the word counting logic re. CJK languages.

People not happy with the result have other options (plainify, summary in front matter, manual split)

Shout if you disagree.
@bep bep added this to the v0.133.0 milestone Aug 17, 2024
@bep bep self-assigned this Aug 17, 2024
bep added a commit to bep/hugo that referenced this issue Aug 17, 2024
@bep
Add Page.Contents with scope support
3f7ee76 
Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
bep added a commit to bep/hugo that referenced this issue Aug 23, 2024
@bep
Add Page.Contents with scope support
7bd37f1 
Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 25, 2024
@bep
Add Page.Contents with scope support
3d2bb94 
Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 28, 2024
@bep
Add Page.Contents with scope support
fc8a1e9 
Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 28, 2024
@bep
Add Page.Contents with scope support
2c008ca 
Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 28, 2024
@bep
Add Page.Contents with scope support
3bece67 
Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 28, 2024
@bep
Add Page.Contents with scope support
a04cb1a 
Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 28, 2024
@bep
Add Page.Contents with scope support
af0c48c 
Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 29, 2024
@bep
Add Page.Contents with scope support
2871e8b 
Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 29, 2024
@bep
Add Page.Contents with scope support
7b9a8b5 
Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 29, 2024
@bep
Add Page.Contents with scope support
cbf0dfc 
Note that this also adds a new `.ContentWithoutSummary` method, and to do that we had to unify the different summary types:

Both `auto` and `manual` now returns HTML. Before this commit, `auto` would return plain text. This could be considered to be a slightly breaking change, but for the better: Now you can treat the `.Summary` the same without thinking about where it comes from, and if you want plain text, pipe it into `{{ .Summary | plainify }}`.

Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 29, 2024
@bep
Add Page.Contents with scope support
4320376 
Note that this also adds a new `.ContentWithoutSummary` method, and to do that we had to unify the different summary types:

Both `auto` and `manual` now returns HTML. Before this commit, `auto` would return plain text. This could be considered to be a slightly breaking change, but for the better: Now you can treat the `.Summary` the same without thinking about where it comes from, and if you want plain text, pipe it into `{{ .Summary | plainify }}`.

Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 29, 2024
@bep
Add Page.Contents with scope support
12f294d 
Note that this also adds a new `.ContentWithoutSummary` method, and to do that we had to unify the different summary types:

Both `auto` and `manual` now returns HTML. Before this commit, `auto` would return plain text. This could be considered to be a slightly breaking change, but for the better: Now you can treat the `.Summary` the same without thinking about where it comes from, and if you want plain text, pipe it into `{{ .Summary | plainify }}`.

Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 29, 2024
@bep
Add Page.Contents with scope support
462f9e0 
Note that this also adds a new `.ContentWithoutSummary` method, and to do that we had to unify the different summary types:

Both `auto` and `manual` now returns HTML. Before this commit, `auto` would return plain text. This could be considered to be a slightly breaking change, but for the better: Now you can treat the `.Summary` the same without thinking about where it comes from, and if you want plain text, pipe it into `{{ .Summary | plainify }}`.

Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 29, 2024
@bep
Add Page.Contents with scope support
3851107 
Note that this also adds a new `.ContentWithoutSummary` method, and to do that we had to unify the different summary types:

Both `auto` and `manual` now returns HTML. Before this commit, `auto` would return plain text. This could be considered to be a slightly breaking change, but for the better: Now you can treat the `.Summary` the same without thinking about where it comes from, and if you want plain text, pipe it into `{{ .Summary | plainify }}`.

Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 29, 2024
@bep
Add Page.Contents with scope support
f4d12ba 
Note that this also adds a new `.ContentWithoutSummary` method, and to do that we had to unify the different summary types:

Both `auto` and `manual` now returns HTML. Before this commit, `auto` would return plain text. This could be considered to be a slightly breaking change, but for the better: Now you can treat the `.Summary` the same without thinking about where it comes from, and if you want plain text, pipe it into `{{ .Summary | plainify }}`.

Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 29, 2024
@bep
Add Page.Contents with scope support
b030963 
Note that this also adds a new `.ContentWithoutSummary` method, and to do that we had to unify the different summary types:

Both `auto` and `manual` now returns HTML. Before this commit, `auto` would return plain text. This could be considered to be a slightly breaking change, but for the better: Now you can treat the `.Summary` the same without thinking about where it comes from, and if you want plain text, pipe it into `{{ .Summary | plainify }}`.

Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
bep added a commit to bep/hugo that referenced this issue Aug 29, 2024
@bep
Add Page.Contents with scope support
fe6c323 
Note that this also adds a new `.ContentWithoutSummary` method, and to do that we had to unify the different summary types:

Both `auto` and `manual` now returns HTML. Before this commit, `auto` would return plain text. This could be considered to be a slightly breaking change, but for the better: Now you can treat the `.Summary` the same without thinking about where it comes from, and if you want plain text, pipe it into `{{ .Summary | plainify }}`.

Fixes gohugoio#8680
Fixes gohugoio#12761
Fixes gohugoio#12778
Fixes gohugoio#716
@bep bep closed this as completed in 3760926 Aug 29, 2024
@bep bep modified the milestones: v0.133.0, v0.134.0 Aug 29, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.134.0
Development

No branches or pull requests
1 participant
@bep