-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
gopls/internal/cache: prime goimports cache asynchronously
Gopls' refresh of the goimports resolver already introduces non-determinism into imports operations: gopls does not observe changes until the asynchronous refresh occurs. This change allows operations to continue to run on the stale resolver until a new resolver is ready. Due to inherent raciness, it's hard to benchmark the impact of this change: one would have to catch gopls during a refresh, which occurs at an automatically adjusted pacing. Also update TODOs. Fixes golang/go#59216 Change-Id: I303df998d804c9a1cd1c0e307872d1d271eed601 Reviewed-on: https://go-review.googlesource.com/c/tools/+/561235 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Alan Donovan <adonovan@google.com>
- Loading branch information
Showing
4 changed files
with
78 additions
and
46 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters