Skip to content

Commit

Permalink
gopls/internal/test/marker: skip on LUCI solaris builders
Browse files Browse the repository at this point in the history
Fixes golang/go#64473

Change-Id: I373b8fa2bb42aad711686b6b907ac56d0e8d452b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/562035
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Robert Findley <rfindley@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
  • Loading branch information
findleyr committed Feb 6, 2024
1 parent 08bd728 commit 8fcb5f0
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion gopls/internal/test/marker/marker_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,11 @@ func TestMain(m *testing.M) {
func Test(t *testing.T) {
if testing.Short() {
builder := os.Getenv("GO_BUILDER_NAME")
if strings.HasPrefix(builder, "darwin-") || builder == "solaris-amd64-oraclerel" {
// Note that HasPrefix(builder, "darwin-" only matches legacy builders.
// LUCI builder names start with x_tools-goN.NN.
// We want to exclude solaris on both legacy and LUCI builders, as
// it is timing out.
if strings.HasPrefix(builder, "darwin-") || strings.Contains(builder, "solaris") {
t.Skip("golang/go#64473: skipping with -short: this test is too slow on darwin and solaris builders")
}
}
Expand Down

0 comments on commit 8fcb5f0

Please sign in to comment.