Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipv6 support to port: esp-idf: libcoap #647

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Conversation

MarkoPura
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Oct 4, 2024

Visit the preview URL for this PR (updated for commit 5d660c7):

https://golioth-firmware-sdk-doxygen-dev--pr647-add-ipv6-to-li-67m0oegg.web.app

(expires Fri, 11 Oct 2024 17:46:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9993e61697a3983f3479e468bcb0b616f9a0578

src/Kconfig.coap Outdated Show resolved Hide resolved
@MarkoPura MarkoPura marked this pull request as ready for review October 4, 2024 16:35
@sam-golioth
Copy link
Contributor

Okay, I know I said put in the golioth_sdk folder, but now I think it should go in a new Kconfig file in the port/esp_idf/components/coap folder.

@MarkoPura
Copy link
Contributor Author

While I was pasting it, I thought the same thing.

Signed-off-by: Marko Puric <marko@golioth.io>
Compile in libcoap IPv6 support when LIBCOAP_ENABLE_IPV6_SUPPORT
is enabled.

Signed-off-by: Marko Puric <marko@golioth.io>
Copy link
Contributor

@sam-golioth sam-golioth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarkoPura!

@MarkoPura MarkoPura merged commit f43ac25 into main Oct 4, 2024
59 of 69 checks passed
@MarkoPura MarkoPura deleted the add-ipv6-to-libcoap branch October 4, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants