Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register HTTP client views for stats #1787

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Register HTTP client views for stats #1787

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
582ff15
Register HTTP client views for stats
linzhp Aug 27, 2022
5461886
Adding ServerRequestBytesView and ServerRequestCountByMethod
linzhp Sep 21, 2022
4ba8282
Merge branch 'main' into views
manugupt1 Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions pkg/observ/stats.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ import (
"net/http"
"time"

"contrib.go.opencensus.io/exporter/prometheus"
"contrib.go.opencensus.io/exporter/stackdriver"
datadog "github.com/DataDog/opencensus-go-exporter-datadog"
"github.com/gomods/athens/pkg/errors"
"github.com/gorilla/mux"
"contrib.go.opencensus.io/exporter/prometheus"
"go.opencensus.io/plugin/ochttp"
"go.opencensus.io/stats/view"
)
Expand Down Expand Up @@ -92,7 +92,17 @@ func registerStatsStackDriverExporter(projectID string) (func(), error) {
// registerViews register stats which should be collected in Athens
func registerViews() error {
const op errors.Op = "observ.registerViews"
if err := view.Register(ochttp.DefaultServerViews...); err != nil {
if err := view.Register(
linzhp marked this conversation as resolved.
Show resolved Hide resolved
ochttp.ServerRequestCountView,
ochttp.ServerResponseBytesView,
ochttp.ServerLatencyView,
ochttp.ServerResponseCountByStatusCode,
ochttp.ServerRequestBytesView,
ochttp.ServerRequestCountByMethod,
ochttp.ClientReceivedBytesDistribution,
ochttp.ClientRoundtripLatencyDistribution,
ochttp.ClientCompletedCount,
); err != nil {
return errors.E(op, err)
}

Expand Down