feat: add non-root user to docker image #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manugupt1
reviewed
Mar 2, 2023
manugupt1
approved these changes
Mar 3, 2023
DrPsychick
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
In many modern deployment environments, root containers are not allowed. While it is simple to switch the user on the fly, that user needs to have a home directory for this to work.
How is the fix applied?
A non-root user
athensuid/gid 1000 is created in the docker image, but not used by default. As existing users will still want to userootfor this to be non-breaking, the new user is not used by default. Documentation on the non-root user has also been added to make this change discoverable.