Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: rename Datatype into DataType #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

all: rename Datatype into DataType #9

wants to merge 1 commit into from

Conversation

sbinet
Copy link
Member

@sbinet sbinet commented Aug 10, 2017

Fixes #8.

@sbinet sbinet requested a review from kortschak August 10, 2017 14:52
@kortschak
Copy link
Member

Sorry, I'm having second thoughts about this change. I'm thinking about how much we can lend from type/kind naming in the reflect package; under this we would have Datatype=>Type and Class=>Kind. The single bit of grit that is getting in the way is that we have a type-like type associated with the Identifier type, currently called IType. I think maybe that should become IdentifierType (much as the long name is unpleasant). While that's happening, the Id() method should become ID() There are also a few cases where N* is used where Num* would be preferable.

@donkahlero donkahlero mentioned this pull request Jul 8, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kortschak kortschak Awaiting requested review from kortschak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbinet @kortschak