Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring validations #8

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Refactoring validations #8

merged 2 commits into from
Jan 23, 2024

Conversation

adishagarwal
Copy link
Contributor

moved simple validations to the main file, util now has only two utilities:

  1. validateAndParseFailureCriteria
  2. isFailureCriteriaSatisfied

@adishagarwal adishagarwal requested a review from a team as a code owner January 22, 2024 13:39
@adishagarwal adishagarwal linked an issue Jan 22, 2024 that may be closed by this pull request
src/main.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
@adishagarwal adishagarwal merged commit c40631e into main Jan 23, 2024
1 check passed
@adishagarwal adishagarwal deleted the adishag/refactor-validations branch January 23, 2024 05:04
verbanicm pushed a commit that referenced this pull request Jan 25, 2024
## What's Changed
* chore: add codeowners by @verbanicm in
#1
* Add code for analyze-code-security-scc action by @adishagarwal in
#2
* Update deps by @sethvargo in
#6
* Update deps by @sethvargo in
#7
* Refactoring validations by @adishagarwal in
#8
* Added integration tests and updated documentation by @adishagarwal in
#9
* fix: docs and package version by @verbanicm in
#12
* flipping endpoint to prod by @adishagarwal in
#10
* updating dist by @adishagarwal in
#13
* updated action name for marketplace by @sanyam803 in
#16
* Adding unit tests by @adishagarwal in
#14

## New Contributors
* @verbanicm made their first contribution in
#1
* @adishagarwal made their first contribution in
#2
* @sethvargo made their first contribution in
#6
* @sanyam803 made their first contribution in
#16

**Full Changelog**:
https://github.com/google-github-actions/analyze-code-security-scc/commits/9fd41cea55e56aeade94fb23befbe0a415018bd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Refactor validations
4 participants