Add ListBuilder.of and SetBuilder.of contructors
#298
Conversation
Similar to `BuiltList.of`, they expect a typed iterable.
There was a problem hiding this comment.
Thanks!
One suggestion for the implementation :)
I think the toBuilder methods on BuiltList and BuiltSet should probably be updated to use this instead of the other constructor.
Re: testing, a simple call of the new constructor with [1, 2, 3] and check that those values end up in the builder seems sufficient for correctness :)
It would also be good to have a test like the existing "converts to BuiltList without copying" showing that the constructor does not immediately copy a BuiltList. There should have been such a test for the old constructor already ... but if it's no longer used in toBuilder then that's less important :)
Please also add to CHANGELOG.md.
lib/src/list/list_builder.dart
Outdated
| @@ -15,6 +15,9 @@ class ListBuilder<E> { | |||
| late List<E> _list; | |||
| _BuiltList<E>? _listOwner; | |||
|
|
|||
| /// Instantiates with elements from an [Iterable<E>]. | |||
| factory ListBuilder.of(Iterable<E> elements) => ListBuilder<E>(elements); | |||
There was a problem hiding this comment.
This ends up calling replace which doesn't benefit from the collection type being known, how about adding a _replaceOf method which uses List.of instead of List.from, then calling that here.
Private because the end goal is that "replace" turns into "replaceOf", but we can worry about that later :)
iinozemtsev
force-pushed
the
list_set_of
branch
from
9d9a74d
to
e6adefc
Compare
Similar to
BuiltList.of, they expect a typed iterable.