Zero allocation fix #226
Merged
Zero allocation fix #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2017
sergiud
force-pushed
the
zero-allocation-log-failure
branch
from
093c9c7
to
40e4070
Compare
sergiud
force-pushed
the
zero-allocation-log-failure
branch
from
40e4070
to
2fe6508
Compare
|
@shinh The PR is ready to be merged! |
|
Looks great, thanks! I'm fairly sure LOG(INFO) is still allocation free, but have you somehow checked this didn't increase memory allocation? |
|
I have no numbers. However, @hansres has been running the patch for an extended period of time and maybe he can comment on that. Nevertheless, since there's just one static array per thread, the memory consumpution should not bet higher than without TLS. |
durswd
pushed a commit
to durswd/glog
that referenced
this pull request
Sep 2, 2019
Zero allocation fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to PR #217 which does not allocate dynamic memory.