Fix redefined warnings from config.h #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiud
requested changes
Mar 20, 2018
src/config.h.cmake.in
Outdated
| @@ -1,3 +1,6 @@ | |||
| #ifndef __GLOG_CONFIG_H__ | |||
| #define __GLOG_CONFIG_H__ | |||
There was a problem hiding this comment.
Macro names with prefix underscores are reserved for compiler use. Just change the define into GLOG_CONFIG_H. That should do just fine.
The issue was caused by config.h header being included from both header files and implementation files. Proposed solution is to have regular header guard in the generated config.h. Benefit of this solution is that it's least intrusive. Downside is that it only solves issue for CMake build system, and autoconf one is not fixed since header template is automatically generated by autoheader who does not add header guard.
sergeyvfx
force-pushed
the
reincluded-config
branch
from
f4ffab8
to
418f902
Compare
|
The patch should now be updated with removed underscores. |
durswd
pushed a commit
to durswd/glog
that referenced
this pull request
Sep 2, 2019
Fix redefined warnings from config.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was caused by config.h header being included from both
header files and implementation files.
Proposed solution is to have regular header guard in the generated
config.h. Benefit of this solution is that it's least intrusive.
Downside is that it only solves issue for CMake build system, and
autoconf one is not fixed since header template is automatically
generated by autoheader who does not add header guard.