Fix mingw cross compile #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
- fix dbhelp.h include - fix dbghelp check and link
- check in cmake if localtime_r exists - if localtime_r is missing (MSVC, mingw-w64 on linux) redefine it using localtime_s
NeroBurner
force-pushed
the
fix_mingw_cross_compile
branch
from
5116751
to
364fad5
Compare
|
CLAs look good, thanks! |
durswd
pushed a commit
to durswd/glog
that referenced
this pull request
Sep 2, 2019
Fix mingw cross compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset fixes cross compilation with mingw-w64 from Ubuntu 18.04 to Windows and mingw-w64 compiles on Appveyor
Referencing #323
Compilations for MSVC 2017 win64 and mingw-w64 7.2.0 can be seen here
https://ci.appveyor.com/project/NeroBurner/glog/build/1.0.42/job/ivk3i16iag6ro3mr
Compilations with Ubuntu 14.04 (amd64/i386), Ubuntu 16.04 (amd64/i386), Ubuntu 18.04 (amd64) and cross compilation for Windows with mingw-w64 on Ubuntu 18.04 can be seen here
https://travis-ci.org/NeroBurner/glog/builds/386575502
I'll try to cleanup the CI pipeline so that it is possible to be merged an a later pull request