Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors with BUILD_SHARED_LIBS=ON for Visual Studio 2017. #344

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

dzung-hoang
Copy link
Contributor

@dzung-hoang dzung-hoang commented Jul 16, 2018

Fixes #343.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@dzung-hoang
Copy link
Contributor Author

I signed the CLA.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@sergiud sergiud merged commit 8d7a107 into google:master Jul 16, 2018
durswd pushed a commit to durswd/glog that referenced this pull request Sep 2, 2019
Fix errors with BUILD_SHARED_LIBS=ON for Visual Studio 2017 (fixes google#343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants