Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the symlink creation bug if using bazel #600

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Conversation

zoukyle
Copy link

@zoukyle zoukyle commented Dec 17, 2020

This will fix #599

@google-cla
Copy link

google-cla bot commented Dec 17, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Dec 17, 2020
@zoukyle
Copy link
Author

zoukyle commented Dec 17, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Dec 17, 2020
@sergiud sergiud requested a review from drigz February 13, 2021 10:53
Copy link
Member

@drigz drigz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bazel/glog.bzl Show resolved Hide resolved
@drigz drigz merged commit 6d14ac3 into google:master Feb 20, 2021
@sergiud sergiud added this to the 0.5 milestone Mar 30, 2021
@sergiud sergiud mentioned this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No system link created along with the log files
4 participants