Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added emscripten support #846

Merged
merged 1 commit into from
Aug 4, 2022
Merged

added emscripten support #846

merged 1 commit into from
Aug 4, 2022

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Aug 4, 2022

Fixes #828
Fixes #729

@sergiud sergiud added this to the 0.7 milestone Aug 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #846 (663fe94) into master (a34226c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #846   +/-   ##
=======================================
  Coverage   73.19%   73.19%           
=======================================
  Files          17       17           
  Lines        3279     3279           
=======================================
  Hits         2400     2400           
  Misses        879      879           
Impacted Files Coverage Δ
src/glog/logging.h.in 80.00% <ø> (ø)
src/logging.cc 74.67% <ø> (ø)
src/raw_logging.cc 100.00% <ø> (ø)
src/symbolize.cc 64.11% <ø> (ø)
src/utilities.h 100.00% <ø> (ø)
src/stacktrace_unwind-inl.h 92.59% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sergiud sergiud merged commit 6ed0c9e into master Aug 4, 2022
@sergiud sergiud deleted the emscripten branch August 4, 2022 20:52
sergiud pushed a commit that referenced this pull request Aug 16, 2022
Since #846, `HAVE_UNWIND_H`  is not really in use. Instead we should use `HAVE__UNWIND_BACKTRACE` and `HAVE__UNWIND_GETIP` (added in #846). To prevent that from happening again, also added Bazel tests that confirm stacktrace are still working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform not supported by glog for webassembly Support for WASM export
2 participants