Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: Prevent LogStream constructor from being discarded #925

Merged
merged 1 commit into from
May 25, 2023

Conversation

ekilmer
Copy link
Contributor

@ekilmer ekilmer commented May 25, 2023

Fixes linker error reported in #922

closes #922

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Merging #925 (29bec1b) into master (888f939) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
+ Coverage   73.57%   73.85%   +0.27%     
==========================================
  Files          17       17              
  Lines        3251     3251              
==========================================
+ Hits         2392     2401       +9     
+ Misses        859      850       -9     
Impacted Files Coverage Δ
src/glog/logging.h.in 80.28% <ø> (ø)

... and 1 file with indirect coverage changes

@sergiud sergiud added the bug label May 25, 2023
@sergiud sergiud added this to the 0.7 milestone May 25, 2023
@sergiud
Copy link
Collaborator

sergiud commented May 25, 2023

Thanks!

@sergiud sergiud merged commit 22491eb into google:master May 25, 2023
@ekilmer ekilmer deleted the fix-LogStream-linker-error branch May 25, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linker error 'construction vtable ... LogMessage::LogStream'
3 participants