Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output information about skipped tests in xml output #2767

Merged
merged 5 commits into from
May 28, 2020

Conversation

mvoorsluys
Copy link
Contributor

This pull request adds two things to the xml output:

  • The number of skipped tests inside a suite. (As a property, like the number of failures)
  • On skipped tests it also adds a skipped element to the xml.

I followed the JUnit description in https://llg.cubic.org/docs/junit/

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

The extra tests check that the xml output is correct when a failure occurs before skipping, and that the right skip message is added to the file.

The json file had to be fixed because it's the same executable.
@zhangxy988
Copy link
Contributor

Please sign the CLA and make sure the tests pass.

@mvoorsluys
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 2, 2020
@mvoorsluys mvoorsluys marked this pull request as ready for review April 2, 2020 18:02
@mvoorsluys
Copy link
Contributor Author

@zhangxy988 The tests are passing, but the travis check remains pending. I don't know how I can solve this. The CLA has been resolved.

@mvoorsluys
Copy link
Contributor Author

mvoorsluys commented Apr 3, 2020

Fixes #2728

@CJ-Johnson
Copy link
Contributor

Thank you, we have started internal review. Please don’t push any more changes into this PR as they might be overwritten. (313176466)

derekmauro added a commit that referenced this pull request May 27, 2020
derekmauro added a commit that referenced this pull request May 28, 2020
@derekmauro derekmauro merged commit 07beabd into google:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants