Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant (.&. 127) from putVarInt #396

Merged
merged 1 commit into from
Aug 15, 2020
Merged

Conversation

judah
Copy link
Collaborator

@judah judah commented Aug 14, 2020

Some evidence of that redundancy:

> quickCheck (\(x :: Word64) -> (fromIntegral (x .|. 128) :: Word8) == (fromIntegral (x .&. 127 .|. 128) :: Word8))
+++ OK, passed 100 tests.

Some evidence of that redundancy:
```
> quickCheck (\(x :: Word64) -> (fromIntegral (x .|. 128) :: Word8) == (fromIntegral (x .&. 127 .|. 128) :: Word8))
+++ OK, passed 100 tests.
```
@google-cla
Copy link

google-cla bot commented Aug 14, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 14, 2020
@judah judah added the cla: yes label Aug 14, 2020
@google-cla
Copy link

google-cla bot commented Aug 14, 2020

☹️ Sorry, but only Googlers may change the label cla: yes.

@google-cla google-cla bot removed the cla: yes label Aug 14, 2020
@judah judah mentioned this pull request Aug 14, 2020
@judah
Copy link
Collaborator Author

judah commented Aug 14, 2020

@blackgnezdo can you please flip the CLA? It's complaining because the commit has a different author; but they already signed it, as confirmed in #382.

@ethercrow
Copy link
Contributor

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Aug 14, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@ethercrow
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 14, 2020
@blackgnezdo blackgnezdo merged commit f1402da into master Aug 15, 2020
@judah judah deleted the ethercrow-patch-1 branch August 15, 2020 20:05
ylecornec pushed a commit to ylecornec/proto-lens that referenced this pull request Feb 19, 2024
Some evidence of that redundancy:
```
> quickCheck (\(x :: Word64) -> (fromIntegral (x .|. 128) :: Word8) == (fromIntegral (x .&. 127 .|. 128) :: Word8))
+++ OK, passed 100 tests.
```

Co-authored-by: Dmitry Ivanov <ethercrow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants