Move generated unit tests to unit/gapic directory #454
Assignees
Comments
|
Seems reasonable |
software-dov
added a commit
to software-dov/gapic-generator-python
that referenced
this issue
Jun 12, 2020
Some GAPICs have a manual layer and corresponding handwritten unit tests. These handwritten surfaces are subject to linting, but the autogenerated portions of the surface should not be. Moving generated unit tests to their own subdirectory makes it easier to remove them from linting rules. implementation for googleapis#454
software-dov
added a commit
that referenced
this issue
Jun 13, 2020
Some GAPICs have a manual layer and corresponding handwritten unit tests. These handwritten surfaces are subject to linting, but the autogenerated portions of the surface should not be. Moving generated unit tests to their own subdirectory makes it easier to remove them from linting rules. implementation for #454
|
Fixed by #456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed we didn't actually lint the generated code in the monolith, and I don't think it's necessary for the microgenerator either. (See .flake8)
Could we move the generated tests to
tests/unit/gapicso flake8 will ignore it with the rule**/gapic/**?We can't blanket ignore
**/unit/**because hybrid libraries (e.g. Pub/Sub) may have hand written unit tests.Related to #425, #323
The text was updated successfully, but these errors were encountered: