Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tests are missing port in comparison #872

Closed
busunkim96 opened this issue May 10, 2021 · 0 comments · Fixed by #873 or #1133
Closed

Some tests are missing port in comparison #872

busunkim96 opened this issue May 10, 2021 · 0 comments · Fixed by #873 or #1133
Assignees
@busunkim96
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@busunkim96
Copy link
Contributor

busunkim96 commented May 10, 2021 •
edited
Loading

Noticed in googleapis/python-aiplatform#377

Correct:

gapic-generator-python/gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2

Lines 1628 to 1629 in 5339db1

create_channel.assert_called_with(
"{{ host }}{% if ":" not in service.host %}:443{% endif %}",

Missing:

gapic-generator-python/gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2

Lines 1705 to 1706 in 5339db1

create_channel.assert_called_with(
"{{ host }}",

@busunkim96 busunkim96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 10, 2021
@busunkim96 busunkim96 self-assigned this May 10, 2021
@busunkim96 busunkim96 changed the title Some tests are missing optional port in comparison Some tests are missing port in comparison May 10, 2021
@busunkim96 busunkim96 mentioned this issue May 10, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue May 12, 2021
@busunkim96
fix: fix incorrectly referenced exceptions, add missing port to tests (…
40078c4 
…#873)

Fixes #872
This was referenced Jan 18, 2022
Merged
Closed
Closed
This was referenced Jan 26, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
1 participant
@busunkim96