Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snippetgen: Use f-strings #960

Closed
busunkim96 opened this issue Jul 23, 2021 · 0 comments · Fixed by #975
Closed

snippetgen: Use f-strings #960

busunkim96 opened this issue Jul 23, 2021 · 0 comments · Fixed by #975
Assignees
@busunkim96
Labels
samplegen Bugs, features, and so forth pertaining to the generation of samples type: cleanup An internal cleanup or hygiene concern.

Comments

@busunkim96
Copy link
Contributor

busunkim96 commented Jul 23, 2021 •
edited
Loading

See discussion at #941 (comment)

We generally recommend sample authors use f-strings rather than .format() for readability. Generated snippets should use f-strings as well.
@busunkim96 busunkim96 added type: cleanup An internal cleanup or hygiene concern. samplegen Bugs, features, and so forth pertaining to the generation of samples labels Jul 23, 2021
@busunkim96 busunkim96 self-assigned this Jul 23, 2021
@busunkim96 busunkim96 mentioned this issue Jul 23, 2021
Merged
@busunkim96 busunkim96 changed the title Use f-strings for snippetgen snippetgen: Use f-strings Jul 23, 2021
@busunkim96 busunkim96 mentioned this issue Aug 20, 2021
Merged
@busunkim96 busunkim96 mentioned this issue Oct 5, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 7, 2021
@busunkim96
chore: make api_schema required for samplegen validator (#1010)
dbfb45a 
I found this change makes it a bit easier to implement #960.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
samplegen Bugs, features, and so forth pertaining to the generation of samples type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(snippetgen): use f-strings in print statements googleapis/gapic-generator-python
1 participant
@busunkim96