GameServerAllocation Actions for Counters and Lists #3117

igooch · 2023-04-21T21:13:37Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Allows for below possible actions at Game Server Allocation:

Allocation actions on counts (increment / decrement)
Allocation actions on lists (append)
Allocation change capacity on counts
Allocation change capacity on lists

Any actions that cannot be performed are no-op, and a warning that there was a no-op gets logged as an event.
An action may be partially completed, i.e. a Counter capacity could be updated, but an increment of the Counter is unable to be performed.

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

agones-bot · 2023-04-21T21:40:41Z

Build Failed 😱

Build Id: 5ea405c7-43d5-422d-ae10-2559e5a52c6d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-22T16:56:38Z

Build Failed 😱

Build Id: 573c1916-fb84-4982-99f3-42fa9cd17a34

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-22T17:51:29Z

Build Succeeded 👏

Build Id: f3453cfa-1e22-4960-ae1d-0df619aa7a2d

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-2473604-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-2473604-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-2473604-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-2473604-amd64
Linux C++ SDK (build): agonessdk-1.32.0-2473604-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-2473604-amd64.zip

A preview of the website (the last 30 builds are retained):

https://2473604-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3117/head:pr_3117 && git checkout pr_3117
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-2473604-amd64

agones-bot · 2023-04-24T16:13:10Z

Build Failed 😱

Build Id: 7edff056-7941-4c63-8d4b-94bf8c498b56

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-24T17:10:25Z

Build Succeeded 👏

Build Id: 7b20f149-aad9-4df7-b6cb-627ad5f56119

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-bfab894-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-bfab894-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-bfab894-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-bfab894-amd64
Linux C++ SDK (build): agonessdk-1.32.0-bfab894-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-bfab894-amd64.zip

A preview of the website (the last 30 builds are retained):

https://bfab894-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3117/head:pr_3117 && git checkout pr_3117
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-bfab894-amd64

agones-bot · 2023-04-24T23:58:58Z

Build Failed 😱

Build Id: e6fbb9c2-8418-4d1f-9bae-9a4b8d8291bf

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-25T01:23:28Z

Build Failed 😱

Build Id: 1af811ba-a38a-4ddc-89cf-8e668150ca97

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-25T21:24:40Z

Build Failed 😱

Build Id: 6d58ce84-088f-4271-8835-08970663ec5d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-04-25T22:44:11Z

Build Failed 😱

Build Id: 4669b8cd-ef2b-462b-8260-575ec120929d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

pkg/gameserverallocations/find_test.go

pkg/apis/agones/v1/gameserver.go

pkg/gameserverallocations/find.go

agones-bot · 2023-04-25T23:56:42Z

Build Failed 😱

Build Id: ce5596cc-491e-4d3b-8880-6e64d9754f0d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

google-oss-prow · 2023-05-09T00:39:27Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, igooch
Once this PR has been reviewed and has the lgtm label, please assign markmandel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2023-05-09T00:40:15Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-05-09T01:18:25Z

Build Failed 😱

Build Id: 28e88068-b3c0-4672-842a-975ef4f8f892

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-05-09T17:01:59Z

Build Failed 😱

Build Id: e93a479e-7978-4fa4-9e5d-214158c3ead1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-05-09T17:54:01Z

Build Failed 😱

Build Id: 548331c0-2d2c-4d3d-8059-ade57f5da6fa

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-05-09T19:02:44Z

Build Failed 😱

Build Id: 61f50861-126b-452d-9d9e-515eb7d9e18a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-05-09T21:10:48Z

Build Failed 😱

Build Id: 56dd5158-40e5-4d21-894c-79bfdc742163

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-05-09T22:13:13Z

Build Failed 😱

Build Id: 62327789-5770-4104-87ad-fcd0cb480e22

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-05-10T06:02:44Z

Build Failed 😱

Build Id: a678af2a-fc50-42c5-8ebe-a1e6b8db3947

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-05-10T06:05:34Z

Build Failed 😱

Build Id: a9e20eb2-8f35-4145-a6ac-cdd492705b87

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-05-10T18:13:19Z

Build Failed 😱

Build Id: e508cbbc-2a72-4b3b-9356-d310a8278863

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-05-10T20:18:39Z

Build Succeeded 👏

Build Id: 94e31b55-6897-467e-b589-0fdacc5bdb8b

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-0ef99cf-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-0ef99cf-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-0ef99cf-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-0ef99cf-amd64
Linux C++ SDK (build): agonessdk-1.32.0-0ef99cf-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-0ef99cf-amd64.zip

A preview of the website (the last 30 builds are retained):

https://0ef99cf-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3117/head:pr_3117 && git checkout pr_3117
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-0ef99cf-amd64

… any counter or list actions as warning events

agones-bot · 2023-05-10T22:50:44Z

Build Succeeded 👏

Build Id: 8076a0cf-802b-40ad-b0cc-7ce375a00f19

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.32.0-6296d8f-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.32.0-6296d8f-linux-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.32.0-6296d8f-amd64
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.32.0-6296d8f-amd64
Linux C++ SDK (build): agonessdk-1.32.0-6296d8f-amd64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.32.0-6296d8f-amd64.zip

A preview of the website (the last 30 builds are retained):

https://6296d8f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3117/head:pr_3117 && git checkout pr_3117
helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-6296d8f-amd64

) * Counts and Lists Actions on Game Server Allocation * Adds test for findGameServerForAllocation * Updates ListAction field to avoid pointer to a list * Generated Files * Moves counter and list action kick to the Allocator.goAdds logging of any counter or list actions as warning events * Updates actions to return single error * Move event recording after successful game server update

google-oss-prow bot added the do-not-merge/work-in-progress label Apr 21, 2023

google-oss-prow bot requested review from aLekSer and markmandel April 21, 2023 21:13

google-oss-prow bot added the size/XXL label Apr 21, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch from f826c50 to 701104f Compare April 22, 2023 16:47

igooch force-pushed the arbitrary-counts-lists-2716 branch from 701104f to 2473604 Compare April 22, 2023 16:58

igooch force-pushed the arbitrary-counts-lists-2716 branch from 2473604 to 8ca5bd0 Compare April 24, 2023 16:04

google-oss-prow bot added size/XL and removed size/XXL labels Apr 24, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch from 8ca5bd0 to 13d6d36 Compare April 24, 2023 16:04

google-oss-prow bot added size/XXL and removed size/XL labels Apr 24, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from 6247dba to 865a17b Compare April 24, 2023 23:56

igooch marked this pull request as ready for review April 24, 2023 23:58

google-oss-prow bot removed the do-not-merge/work-in-progress label Apr 24, 2023

google-oss-prow bot requested a review from EricFortin April 24, 2023 23:59

igooch force-pushed the arbitrary-counts-lists-2716 branch from 5750c4d to 642f466 Compare April 25, 2023 22:24

igooch force-pushed the arbitrary-counts-lists-2716 branch from 642f466 to 4fb3162 Compare April 25, 2023 22:50

gongmax reviewed Apr 25, 2023

View reviewed changes

pkg/gameserverallocations/find_test.go Outdated Show resolved Hide resolved

pkg/apis/agones/v1/gameserver.go Outdated Show resolved Hide resolved

pkg/gameserverallocations/find.go Outdated Show resolved Hide resolved

google-oss-prow bot assigned gongmax May 9, 2023

google-oss-prow bot added the lgtm label May 9, 2023

google-oss-prow bot removed the lgtm label May 9, 2023

igooch force-pushed the arbitrary-counts-lists-2716 branch from 420dd4d to 8f6ccdd Compare May 9, 2023 20:41

igooch force-pushed the arbitrary-counts-lists-2716 branch from 8f6ccdd to 0ef99cf Compare May 10, 2023 17:14

igooch added 7 commits May 10, 2023 21:47

Counts and Lists Actions on Game Server Allocation

31b7aae

Adds test for findGameServerForAllocation

923f9ec

Updates ListAction field to avoid pointer to a list

24ca606

Generated Files

85ff20b

Moves counter and list action kick to the Allocator.goAdds logging of…

7707ce6

… any counter or list actions as warning events

Updates actions to return single error

17398eb

Move event recording after successful game server update

6296d8f

igooch force-pushed the arbitrary-counts-lists-2716 branch from 0ef99cf to 6296d8f Compare May 10, 2023 21:48

gongmax merged commit ae8c714 into googleforgames:main May 10, 2023

Kalaiselvi84 added the kind/feature New features for Agones label May 18, 2023

igooch mentioned this pull request Jan 18, 2024

Request for igooch to become Approver #3600

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GameServerAllocation Actions for Counters and Lists #3117

GameServerAllocation Actions for Counters and Lists #3117

igooch commented Apr 21, 2023 •

edited

Loading

agones-bot commented Apr 21, 2023

agones-bot commented Apr 22, 2023

agones-bot commented Apr 22, 2023

agones-bot commented Apr 24, 2023

agones-bot commented Apr 24, 2023

agones-bot commented Apr 24, 2023

agones-bot commented Apr 25, 2023

agones-bot commented Apr 25, 2023

agones-bot commented Apr 25, 2023

agones-bot commented Apr 25, 2023

google-oss-prow bot commented May 9, 2023

google-oss-prow bot commented May 9, 2023

agones-bot commented May 9, 2023

agones-bot commented May 9, 2023

agones-bot commented May 9, 2023

agones-bot commented May 9, 2023

agones-bot commented May 9, 2023

agones-bot commented May 9, 2023

agones-bot commented May 10, 2023

agones-bot commented May 10, 2023

agones-bot commented May 10, 2023

agones-bot commented May 10, 2023

agones-bot commented May 10, 2023

GameServerAllocation Actions for Counters and Lists #3117

GameServerAllocation Actions for Counters and Lists #3117

Conversation

igooch commented Apr 21, 2023 • edited Loading

agones-bot commented Apr 21, 2023

agones-bot commented Apr 22, 2023

agones-bot commented Apr 22, 2023

agones-bot commented Apr 24, 2023

agones-bot commented Apr 24, 2023

agones-bot commented Apr 24, 2023

agones-bot commented Apr 25, 2023

agones-bot commented Apr 25, 2023

agones-bot commented Apr 25, 2023

agones-bot commented Apr 25, 2023

google-oss-prow bot commented May 9, 2023

google-oss-prow bot commented May 9, 2023

agones-bot commented May 9, 2023

agones-bot commented May 9, 2023

agones-bot commented May 9, 2023

agones-bot commented May 9, 2023

agones-bot commented May 9, 2023

agones-bot commented May 9, 2023

agones-bot commented May 10, 2023

agones-bot commented May 10, 2023

agones-bot commented May 10, 2023

agones-bot commented May 10, 2023

agones-bot commented May 10, 2023

igooch commented Apr 21, 2023 •

edited

Loading