Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Golang version 1.20.4 #3137

Merged
merged 3 commits into from
May 4, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented May 3, 2023

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

Upgrade go version to 1.20.4
Upgrade golangci-lint to the version that introduces support of Golang 1.20
Bump example image tags minor version for examples where Go was upgraded.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer

Another PR after this will bump the example images version in the places where they are used. After this PR is merged, we need to build the new version of example images and upload the the registry, otherwise the second PR will not pass CI.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: dfb9ebf5-4800-4522-a14b-9a198d4e7854

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8fa1bde1-ae66-4126-a1b5-d9d0f2c69558

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f9240fd5-8a75-429b-9892-c0cd0e6a5e2a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3137/head:pr_3137 && git checkout pr_3137
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-5bdf009-amd64

@igooch igooch marked this pull request as ready for review May 4, 2023 17:07
@google-oss-prow google-oss-prow bot requested a review from cyriltovena May 4, 2023 17:08
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4e7ed519-7aba-497c-a497-0f576419f09e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3137/head:pr_3137 && git checkout pr_3137
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-18815a5-amd64

Copy link
Collaborator

@gongmax gongmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, igooch
Once this PR has been reviewed and has the lgtm label, please assign cyriltovena for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gongmax gongmax merged commit 3082fdc into googleforgames:main May 4, 2023
@Kalaiselvi84 Kalaiselvi84 added kind/cleanup Refactoring code, fixing up documentation, etc kind/feature New features for Agones labels May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc kind/feature New features for Agones lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants