refactor(allocation): Reimplement the Validate method using "field.ErrorList" #3259

aimuz · 2023-07-12T03:54:42Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind breaking

What this PR does / Why we need it:

ref: #3239
ref: #3255

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

agones-bot · 2023-07-12T04:01:40Z

Build Failed 😱

Build Id: 80bb142b-9989-4610-a8f3-80e92e296f42

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-07-12T04:25:58Z

Build Failed 😱

Build Id: a80ce7b5-444b-4692-912d-cb64f8415504

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-07-12T05:53:12Z

Build Failed 😱

Build Id: e06f6dd4-8ffe-440f-87e9-8f421767e59e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-07-12T06:31:09Z

Build Failed 😱

Build Id: 553fe32b-9c57-4a87-b196-66fd0fe4ecae

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-07-12T07:38:37Z

Build Failed 😱

Build Id: e13d7bf4-51c9-4197-98cf-a45e69639b9f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-07-12T09:02:33Z

Build Succeeded 👏

Build Id: aef9c633-2dc5-4f78-ad38-41ca31e02c94

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://559e801-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3259/head:pr_3259 && git checkout pr_3259
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-559e801-amd64

igooch · 2023-07-12T17:15:34Z

pkg/apis/allocation/v1/gameserverallocation.go

-			Message: "Feature CountsAndLists must be enabled if Counters or Lists are specified",
-			Field:   field,
-		})
+		allErrs = append(allErrs, field.Forbidden(fldPath.Child("counters"), "Feature CountsAndLists must be enabled if Counters or Lists are specified"))


How specific do you want the field path to be? Here there may be the case that "lists" is the field path.

@igooch
Yes, I only processed the counters field, the lists field should have been processed as well, I ignored it

thank you very much

@igooch done

…rorList" Signed-off-by: aimuz <mr.imuz@gmail.com>

agones-bot · 2023-07-13T04:29:43Z

Build Succeeded 👏

Build Id: 92eca973-3de0-46c7-a3bf-6b83b0c2ffed

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://a99a9fe-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3259/head:pr_3259 && git checkout pr_3259
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-a99a9fe-amd64

google-oss-prow · 2023-07-13T22:30:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aimuz, igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2023-07-14T01:04:39Z

Build Succeeded 👏

Build Id: 530902ae-bd20-4601-988b-969a7f284df7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://8cd66cb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3259/head:pr_3259 && git checkout pr_3259
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-8cd66cb-amd64

google-oss-prow · 2023-07-14T01:34:22Z

New changes are detected. LGTM label has been removed.

agones-bot · 2023-07-14T02:45:05Z

Build Succeeded 👏

Build Id: 706115f9-bf37-424f-95ca-5f13f43985c7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://398ca76-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3259/head:pr_3259 && git checkout pr_3259
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-398ca76-amd64

agones-bot · 2023-07-14T05:21:09Z

Build Succeeded 👏

Build Id: 5bcd5397-a20f-47ca-8008-c4d3c3f840bf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://b3757f6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3259/head:pr_3259 && git checkout pr_3259
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-b3757f6-amd64

google-oss-prow bot requested review from aLekSer and roberthbailey July 12, 2023 03:54

google-oss-prow bot added the size/L label Jul 12, 2023

github-actions bot added the kind/breaking Breaking change label Jul 12, 2023

roberthbailey requested review from markmandel and igooch and removed request for aLekSer and roberthbailey July 12, 2023 03:57

aimuz force-pushed the allocation branch from 05e163e to 158b4fc Compare July 12, 2023 04:18

aimuz force-pushed the allocation branch from 158b4fc to 405b0e2 Compare July 12, 2023 05:41

google-oss-prow bot added size/XL and removed size/L labels Jul 12, 2023

aimuz force-pushed the allocation branch from 7ada9a8 to 26c540d Compare July 12, 2023 07:23

aimuz force-pushed the allocation branch from 26c540d to 559e801 Compare July 12, 2023 08:01

igooch approved these changes Jul 12, 2023

View reviewed changes

google-oss-prow bot assigned igooch Jul 12, 2023

google-oss-prow bot added the lgtm label Jul 12, 2023

refactor(allocation): Reimplement the Validate method using "field.Er…

a99a9fe

…rorList" Signed-off-by: aimuz <mr.imuz@gmail.com>

aimuz force-pushed the allocation branch from 559e801 to a99a9fe Compare July 13, 2023 03:28

google-oss-prow bot removed the lgtm label Jul 13, 2023

aimuz requested a review from igooch July 13, 2023 06:36

Merge branch 'main' into allocation

8cd66cb

markmandel approved these changes Jul 13, 2023

View reviewed changes

google-oss-prow bot assigned markmandel Jul 13, 2023

google-oss-prow bot added the lgtm label Jul 13, 2023

markmandel enabled auto-merge (squash) July 13, 2023 22:30

google-oss-prow bot added the approved label Jul 13, 2023

Merge branch 'main' into allocation

398ca76

google-oss-prow bot removed the lgtm label Jul 14, 2023

Merge branch 'main' into allocation

b3757f6

markmandel merged commit 3bf636b into googleforgames:main Jul 14, 2023
2 checks passed

igooch mentioned this pull request Jan 18, 2024

Request for igooch to become Approver #3600

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(allocation): Reimplement the Validate method using "field.ErrorList" #3259

refactor(allocation): Reimplement the Validate method using "field.ErrorList" #3259

aimuz commented Jul 12, 2023

agones-bot commented Jul 12, 2023

agones-bot commented Jul 12, 2023

agones-bot commented Jul 12, 2023

agones-bot commented Jul 12, 2023

agones-bot commented Jul 12, 2023

agones-bot commented Jul 12, 2023

igooch Jul 12, 2023

aimuz Jul 13, 2023

aimuz Jul 13, 2023

agones-bot commented Jul 13, 2023

google-oss-prow bot commented Jul 13, 2023

agones-bot commented Jul 14, 2023

google-oss-prow bot commented Jul 14, 2023

agones-bot commented Jul 14, 2023

agones-bot commented Jul 14, 2023

refactor(allocation): Reimplement the Validate method using "field.ErrorList" #3259

refactor(allocation): Reimplement the Validate method using "field.ErrorList" #3259

Conversation

aimuz commented Jul 12, 2023

agones-bot commented Jul 12, 2023

agones-bot commented Jul 12, 2023

agones-bot commented Jul 12, 2023

agones-bot commented Jul 12, 2023

agones-bot commented Jul 12, 2023

agones-bot commented Jul 12, 2023

igooch Jul 12, 2023

Choose a reason for hiding this comment

aimuz Jul 13, 2023

Choose a reason for hiding this comment

aimuz Jul 13, 2023

Choose a reason for hiding this comment

agones-bot commented Jul 13, 2023

google-oss-prow bot commented Jul 13, 2023

agones-bot commented Jul 14, 2023

google-oss-prow bot commented Jul 14, 2023

agones-bot commented Jul 14, 2023

agones-bot commented Jul 14, 2023