Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Go SDK client Counter functions #3372

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Sep 11, 2023

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Implements the Go SDK client Counter functions

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

@github-actions github-actions bot added the kind/feature New features for Agones label Sep 11, 2023
sdks/go/alpha.go Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 269b9eb4-6493-4923-92ac-d835165a375b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3372/head:pr_3372 && git checkout pr_3372
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-cf44593-amd64

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great, just a note on whether we need that method, and if possible, we don't need to update the date on all the CRD apis?

pkg/client/clientset/versioned/clientset.go Outdated Show resolved Hide resolved
sdks/go/alpha.go Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b2f9f595-3b5b-478e-aeac-11b5c2de25ce

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0c04084e-e825-4285-bd20-b50b03a110b3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3372/head:pr_3372 && git checkout pr_3372
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-c834a24-amd64

sdks/go/alpha.go Show resolved Hide resolved
@google-oss-prow google-oss-prow bot removed the lgtm label Sep 12, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: af231055-76fd-4893-b92c-68b7127e2e5e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3372/head:pr_3372 && git checkout pr_3372
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.35.0-dev-a1b82a7-amd64

@markmandel markmandel merged commit 45e7cb4 into googleforgames:main Sep 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/feature New features for Agones size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants