Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CounterActions and ListActions to Allocation.proto #3407

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Sep 29, 2023

What type of PR is this?

/kind feature

What this PR does / Why we need it:

  • Adds CounterActions and ListActions to Allocation.proto to be consistent with the GameServerAllocationSpec
  • Adds CounterActions and ListActions to the converter for converting between a GameServerAllocation proto and the GameServerAllocationSpec

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

@github-actions github-actions bot added the kind/feature New features for Agones label Sep 29, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0c1a9835-ed61-4d61-951d-8564eaccf27f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 072913b9-e014-446e-8162-9a697363c460

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3407/head:pr_3407 && git checkout pr_3407
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-d2189ca-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 620996dd-571d-4ee7-aa63-97848b5556eb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8e865ab2-8eba-4508-baee-10710cb02bd6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ddf0085e-7042-4c24-ba47-b472aa8adcb6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 01012027-f1e8-444b-9962-96d2fee09caa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3407/head:pr_3407 && git checkout pr_3407
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-390e876-amd64

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@google-oss-prow google-oss-prow bot added the lgtm label Oct 2, 2023
@markmandel markmandel merged commit 4060911 into googleforgames:main Oct 2, 2023
3 checks passed
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants