Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Counter FleetAutoScaler e2e Test #3418

Merged
merged 6 commits into from
Oct 18, 2023
Merged

Adds Counter FleetAutoScaler e2e Test #3418

merged 6 commits into from
Oct 18, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Oct 11, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / Why we need it:

  • Adds FleetAutoScaler e2e Test for Counter
  • Updates fleetautoscalers applyCounterOrListPolicy to never return less than one desired replica when scaling down the fleet, as the fleet cannot scale back up from zero
  • Adds validation that the autoscaler policy MinCapacity for both Counters and LIsts is greater than zero when buffer is a percentage

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5ca7efc3-081d-4a26-afea-0a6d686c4a83

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5855a611-6041-44a8-b95c-e0a236bd5fd1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from ef8b736 to c2c22c8 Compare October 12, 2023 21:45
@igooch igooch marked this pull request as ready for review October 12, 2023 21:45
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7158feff-4ba2-4946-a34f-f89aa6623140

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from c2c22c8 to a4eedef Compare October 13, 2023 18:11
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a430bc7a-4c7f-4d03-8690-3df5ef6cff0c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c26a1d4c-1840-426d-ad9e-14dd64fccfbe

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 24e027b to 662a3e0 Compare October 16, 2023 17:46
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c38456aa-e6e8-4e4d-9f88-fcb82bf310b2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 662a3e0 to 3474e79 Compare October 16, 2023 18:09
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f2c57a36-885c-4d24-8a07-b7a88ac8806f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 3474e79 to 8c1e598 Compare October 16, 2023 18:37
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 12d8dfb4-7ac0-43e0-908c-25bb15496fee

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e7b21d75-27da-41f7-8531-2f5d4be0f15e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 12e7e575-1cb0-4e00-bdf1-ecfe8cbb5d43

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 48fd1ab to a4ba00e Compare October 17, 2023 16:14
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0bd2fd73-7a88-44e1-8b67-3dc1a375173f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from 98b2cd8 to c53bb00 Compare October 17, 2023 18:18
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2b8b57bd-b21a-488d-9ca8-2f52e45c56c4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3418/head:pr_3418 && git checkout pr_3418
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-c53bb00-amd64

@igooch
Change FleetAutoScaler policy for CountsAndLists to never scale to zero
0a4c509
@igooch
Adds validation that MinCapcity is not zero when buffer is a percentage
dad8b43 
Adds additional tests and removes todo comments
@igooch
Changes autoscaler tests to look for allocated and ready replicas
64939c9 
instead of replicas
@igooch
Creates new fleet for each TestCounterAutoscalerAllocated test
5cff9c2 
to prevent intermintent issue with fleet not returning to the base state
@igooch
Adds sorting by name if values are equal to match the same sorting lo…
92c9dec 
…gic as the allocation cache

This should prevent the occasional edge case of equal gameserver available capacity in the gameserverallocation cache e2e test
@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from c53bb00 to 92c9dec Compare October 17, 2023 22:56
markmandel
markmandel approved these changes Oct 18, 2023
View reviewed changes
test/e2e/README.md
To run a single test on your kubectl configured cluster you can optionally include any flags listed
in e2e test args in the agones/build/Makefile such as `FEATURE_GATES="CountsAndLists=true"`:

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@google-oss-prow google-oss-prow bot added the lgtm label Oct 18, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igooch, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel enabled auto-merge (squash) October 18, 2023 00:34
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0de8c444-8e6f-4654-8ace-1fc7c8fb3ab9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3418/head:pr_3418 && git checkout pr_3418
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.36.0-dev-92c9dec-amd64

@markmandel markmandel merged commit 874a0eb into googleforgames:main Oct 18, 2023
3 checks passed
@Kalaiselvi84 Kalaiselvi84 added kind/feature New features for Agones and removed kind/other labels Nov 2, 2023
@igooch igooch mentioned this pull request Jan 18, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@markmandel markmandel

Labels
approved kind/feature New features for Agones lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igooch @agones-bot @markmandel @Kalaiselvi84