Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counter and List Aggregate Fleet Metrics #3528

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Counter and List Aggregate Fleet Metrics #3528

merged 2 commits into from
Dec 8, 2023

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Dec 1, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Adds metrics for Counters and Lists at the Fleet level. Includes Aggregate Count, Aggregate Capacity, Aggregate Allocated Count, and Aggregate Allocated Capacity across the fleet by a Counter or List key.

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: igooch
Once this PR has been reviewed and has the lgtm label, please assign roberthbailey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot added the kind/feature New features for Agones label Dec 1, 2023
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a567ba1c-eb50-4585-af70-49acd9bed08b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from ce19aa3 to 94a2f38 Compare December 1, 2023 23:52
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6a8c5f01-a8a0-4ea8-9d5a-4b16d9e0ae0a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 94a2f38 to aa41068 Compare December 2, 2023 00:04
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: fbf90c6d-23de-419c-a4a7-410d15201b0f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from aa41068 to 99b2522 Compare December 2, 2023 00:19
@google-oss-prow google-oss-prow bot added size/M and removed size/L labels Dec 2, 2023
@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from 47129b0 to b6a4e2c Compare December 2, 2023 00:23
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 372a463d-f517-4fe5-b62b-0d88b47dfc86

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3528/head:pr_3528 && git checkout pr_3528
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-b6a4e2c-amd64

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from b6a4e2c to d69ed8b Compare December 7, 2023 17:58
@github-actions github-actions bot added the size/S label Dec 7, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5b4d5ffe-601a-4e77-850b-48be1d2417b8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3528/head:pr_3528 && git checkout pr_3528
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-d69ed8b-amd64

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 2 times, most recently from f16e60a to 156bba5 Compare December 7, 2023 21:25
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9b7b6427-9c6d-4c84-b698-9a91e41da326

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch 4 times, most recently from 6ec0cbe to 567ff06 Compare December 7, 2023 23:19
@igooch igooch marked this pull request as ready for review December 7, 2023 23:23
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8b76eadf-ed94-4cfd-9e60-61d1f449d8df

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3528/head:pr_3528 && git checkout pr_3528
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-567ff06-amd64

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from 567ff06 to b597493 Compare December 8, 2023 17:28
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fceda590-7b62-425d-b217-7efe143ee747

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3528/head:pr_3528 && git checkout pr_3528
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-b597493-amd64

@igooch igooch force-pushed the arbitrary-counts-lists-2716 branch from b597493 to db07946 Compare December 8, 2023 19:32
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: de67a679-50e1-416d-98f1-c7198f3ba2b0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3528/head:pr_3528 && git checkout pr_3528
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-db07946-amd64

markmandel
markmandel reviewed Dec 8, 2023
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one note.

pkg/metrics/controller_metrics.go Show resolved Hide resolved
pkg/metrics/controller_metrics.go Outdated Show resolved Hide resolved
pkg/metrics/controller_metrics.go Outdated Show resolved Hide resolved
pkg/metrics/controller_test.go Show resolved Hide resolved
@igooch
Updates keyFleetName to keyName for Counters and Lists
f34a9dd 
To be consistent with the tag used by fleets/replica_count
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f48b85fb-b370-48a7-ba01-c91c0815e470

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3528/head:pr_3528 && git checkout pr_3528
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-f34a9dd-amd64

@markmandel markmandel merged commit 735e1cf into googleforgames:main Dec 8, 2023
4 checks passed
@igooch igooch mentioned this pull request Jan 18, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees
No one assigned
Labels
do-not-merge/work-in-progress kind/feature New features for Agones size/M size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igooch @agones-bot @markmandel