[Performance] - Added a new metric inside the allocator to track the success retry rate inside the retry loop #3927

vicentefb · 2024-07-30T00:06:01Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

vicentefb · 2024-07-30T00:11:04Z

agones-bot · 2024-07-30T00:14:18Z

Build Failed 😭

Build Id: 0f7a5893-6cde-4df1-b197-39ec5149f5d0

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-07-30T22:41:30Z

Build Failed 😭

Build Id: fc6bb5e6-26d5-4326-905f-6bca3ccab458

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-07-31T00:32:07Z

Build Succeeded 🥳

Build Id: e2c4011c-aa43-4073-89e1-a3d782d350e9

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.43.0-dev-63b606b
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.43.0-dev-63b606b
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.43.0-dev-63b606b-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.43.0-dev-63b606b
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.43.0-dev-63b606b
Linux C++ SDK (build): agonessdk-1.43.0-dev-63b606b-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.43.0-dev-63b606b.zip

A preview of the website (the last 30 builds are retained):

https://63b606b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3927/head:pr_3927 && git checkout pr_3927
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-63b606b

pkg/gameserverallocations/metrics.go

markmandel · 2024-08-01T23:46:07Z

pkg/gameserverallocations/metrics.go

@@ -82,8 +101,8 @@ func (r *metrics) setStatus(status string) {
 }

 // setError set the latency status tag as error.
-func (r *metrics) setError() {
-	r.mutate(tag.Update(keyStatus, "error"))
+func (r *metrics) setError(errorType string) {


This whole function seems... odd to me.

Any reason we aren't using stats.RecordWithTags() everywhere instead?

We have some nice helpers too:

agones/pkg/metrics/util.go

Lines 45 to 49 in 96c3d26

func recordWithTags(ctx context.Context, mutators []tag.Mutator, ms ...stats.Measurement) {

if err := stats.RecordWithTags(ctx, mutators, ms...); err != nil {

logger.WithError(err).Warn("error while recoding stats")

}

}

Mmmm i'm not entirely sure why we aren't using stats.RecordWithTags(). There's only one other metric in this file which is the latency one and it uses stats.Record(r.ctx, gameServerAllocationsLatency.M(time.Since(r.start).Seconds())) directly. I could update this file and change it in this PR to use stats.RecordWithTags()

Ohhh i think i see why, it first records the metrics and then it does a lot of manipulation with the tags for example: latency.setRequest(gsa) mutates tags same case with latency.setResponse(out) I can probably merge latency.record() and latency.setRequest(gsa) but not sure about latency.setResponse(out) since that happens later in the function and the code can return before that. Wdyt ?

pkg/gameserverallocations/allocator.go

agones-bot · 2024-08-06T16:38:58Z

Build Failed 😭

Build Id: b6259f67-d6b3-45d7-b6e6-1e1e21a141fa

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-08-06T17:02:41Z

Build Failed 😭

Build Id: f9d573da-bd4a-4b60-b785-682b9f7db633

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-08-06T17:25:53Z

Build Failed 😭

Build Id: c6e0a254-23ce-431a-85f7-754694c0b0d6

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-08-06T19:09:26Z

Build Failed 😭

Build Id: 85d95b8d-c99f-489e-9d9c-54f4bbc171a7

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

pkg/gameserverallocations/allocator.go

agones-bot · 2024-08-07T21:08:30Z

Build Failed 😭

Build Id: 639e5381-e7e0-41b8-9d92-cbd2403b32f3

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-08-12T20:52:37Z

Build Failed 😭

Build Id: c7506251-d532-4760-a93e-d1ac4453dc18

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-08-12T22:06:04Z

Build Succeeded 🥳

Build Id: e9f2495f-b9f1-404a-9c8a-7a9d9651c17b

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.43.0-dev-ee53588
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.43.0-dev-ee53588
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.43.0-dev-ee53588-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.43.0-dev-ee53588
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.43.0-dev-ee53588
Linux C++ SDK (build): agonessdk-1.43.0-dev-ee53588-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.43.0-dev-ee53588.zip

A preview of the website (the last 30 builds are retained):

https://ee53588-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3927/head:pr_3927 && git checkout pr_3927
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-ee53588

agones-bot · 2024-08-20T18:23:47Z

Build Succeeded 🥳

Build Id: a58b657d-9dce-4dcf-8272-32346d40012a

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.43.0-dev-199be7d
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.43.0-dev-199be7d
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.43.0-dev-199be7d-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.43.0-dev-199be7d
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.43.0-dev-199be7d
Linux C++ SDK (build): agonessdk-1.43.0-dev-199be7d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.43.0-dev-199be7d.zip

A preview of the website (the last 30 builds are retained):

https://199be7d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3927/head:pr_3927 && git checkout pr_3927
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-199be7d

pkg/gameserversets/controller.go

pkg/gameserversets/metrics.go

pkg/gameserverallocations/metrics.go

agones-bot · 2024-08-21T07:47:38Z

Build Succeeded 🥳

Build Id: cafa4a1f-80fc-4c9c-a894-6609a0f71e50

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.43.0-dev-26953dd
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.43.0-dev-26953dd
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.43.0-dev-26953dd-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.43.0-dev-26953dd
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.43.0-dev-26953dd
Linux C++ SDK (build): agonessdk-1.43.0-dev-26953dd-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.43.0-dev-26953dd.zip

A preview of the website (the last 30 builds are retained):

https://26953dd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3927/head:pr_3927 && git checkout pr_3927
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-26953dd

pkg/gameserverallocations/allocator.go

site/content/en/docs/Guides/metrics.md

pkg/gameserversets/metrics.go

agones-bot · 2024-08-21T23:15:57Z

Build Succeeded 🥳

Build Id: 4c0e4600-5979-4e88-8de6-be52ec42a260

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.43.0-dev-0315b59
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.43.0-dev-0315b59
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.43.0-dev-0315b59-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.43.0-dev-0315b59
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.43.0-dev-0315b59
Linux C++ SDK (build): agonessdk-1.43.0-dev-0315b59-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.43.0-dev-0315b59.zip

A preview of the website (the last 30 builds are retained):

https://0315b59-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3927/head:pr_3927 && git checkout pr_3927
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-0315b59

agones-bot · 2024-08-22T01:12:57Z

Build Succeeded 🥳

Build Id: 42c40261-f22c-4900-a08f-2fdf11e231ee

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.43.0-dev-76bd6d4
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.43.0-dev-76bd6d4
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.43.0-dev-76bd6d4-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.43.0-dev-76bd6d4
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.43.0-dev-76bd6d4
Linux C++ SDK (build): agonessdk-1.43.0-dev-76bd6d4-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.43.0-dev-76bd6d4.zip

A preview of the website (the last 30 builds are retained):

https://76bd6d4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3927/head:pr_3927 && git checkout pr_3927
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-76bd6d4

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://redirect.github.com/googleforgames/agones)) | minor | `1.42.0` -> `1.43.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.43.0`](https://redirect.github.com/googleforgames/agones/releases/tag/v1.43.0) [Compare Source](https://redirect.github.com/googleforgames/agones/compare/v1.42.0...v1.43.0) This is the 1.43.0 release of Agones. In this release, we updated the supported Kubernetes version, added a new scheduled autoscaler, as well as Unity support for Counters and Lists.. - **Kubernetes 1.30 Support** With this release, the Kubernetes support matrix for Agones is now 1.28, 1.29 and 1.30. - **Alpha support for ScheduledAutoscaler** This provides the ability to have Fleet autoscaler scheduling with the feature flag `ScheduledAutoscaler`, to allow you to schedule what level of autoscaling you would like on a schedule or between dates, giving you more control over your autoscaling needs. - **Unity SDK: Counters and Lists** We now have support for `GameServer` [Counters and Lists](https://agones.dev/site/docs/guides/counters-and-lists/) with our Unity SDK! - **New Helm Installation Configuration Options** Two new installation options! We made the parameters that control how fast we scale up and down `GameServers` configurable, so you can see how fast your Kubernetes control plane really is when spinning up lots of `GameServer` instances. We also have new Helm configuration options that allow the use of the host network for the Agones controller and extensions for AWS EKS when using Cilium. - **Beta support for Passthrough PortPolicy on GKE Autopilot** We’ve graduated Passthrough Port Policy support from Alpha to Beta on GKE Autopilot, which you can now enable using the feature flag `AutopilotPassthroughPort`.  #### What's Changed ##### Breaking changes - Revert "Update Supported Kubernetes to 1.28, 1.29, 1.30 ([#3933](https://redirect.github.com/googleforgames/agones/issues/3933))" by [@gongmax](https://redirect.github.com/gongmax) in [googleforgames/agones#3952 ##### Implemented enhancements - Add Option to Use Host Network and Configure Ports by [@Orza](https://redirect.github.com/Orza) in [googleforgames/agones#3895 - Graduate Passthrough Port Policy to Beta on Autopilot by [@vicentefb](https://redirect.github.com/vicentefb) in [googleforgames/agones#3916 - Agones Unity SDK development setup instructions + Agones Unity SDK Ready test by [@aallbrig](https://redirect.github.com/aallbrig) in [googleforgames/agones#3887 - feat: Add API Changes and Validation for FleetAutoscaler Schedule/Chain Policy by [@indexjoseph](https://redirect.github.com/indexjoseph) in [googleforgames/agones#3893 - feat: Adds autoscaling logic for new Chain and Schedule policies by [@indexjoseph](https://redirect.github.com/indexjoseph) in [googleforgames/agones#3929 - Adds basic framework for the in place Agones upgrades test controller by [@igooch](https://redirect.github.com/igooch) in [googleforgames/agones#3956 - \[Performance] - Added a new metric inside the allocator to track the success retry rate inside the retry loop by [@vicentefb](https://redirect.github.com/vicentefb) in [googleforgames/agones#3927 - Make the parameters that limits the number of GameServers to add configurable by [@vicentefb](https://redirect.github.com/vicentefb) in [googleforgames/agones#3950 - feat: Adds e2e tests for chain/schedule policy and bump ScheduledAutoscaler to Alpha by [@indexjoseph](https://redirect.github.com/indexjoseph) in [googleforgames/agones#3946 - Implement CountsAndLists for Unity SDK + Tests by [@ZeroParticle](https://redirect.github.com/ZeroParticle) in [googleforgames/agones#3883 ##### Fixed bugs - Resolves `make site-server` issue [#3885](https://redirect.github.com/googleforgames/agones/issues/3885) by [@aallbrig](https://redirect.github.com/aallbrig) in [googleforgames/agones#3914 ##### Other - Preparation for Release v1.43.0 by [@kamaljeeti](https://redirect.github.com/kamaljeeti) in [googleforgames/agones#3910 - Introduce external resource(s) on multiplayer game programming to docs by [@aallbrig](https://redirect.github.com/aallbrig) in [googleforgames/agones#3884 - Added line of code to update failure count details inside runscenario by [@vicentefb](https://redirect.github.com/vicentefb) in [googleforgames/agones#3915 - updated golang upgrade template by [@ashutosji](https://redirect.github.com/ashutosji) in [googleforgames/agones#3902 - Changes for GitHub/Cloud Build app integration by [@zmerlynn](https://redirect.github.com/zmerlynn) in [googleforgames/agones#3918 - Meta: Contributor role by [@markmandel](https://redirect.github.com/markmandel) in [googleforgames/agones#3922 - Fix allocator metrics endpoint by [@vicentefb](https://redirect.github.com/vicentefb) in [googleforgames/agones#3921 - Meta: Contributor => Collaborator by [@markmandel](https://redirect.github.com/markmandel) in [googleforgames/agones#3928 - Rewrite agones-bot, commit to Agones repo by [@zmerlynn](https://redirect.github.com/zmerlynn) in [googleforgames/agones#3923 - Small cleanup of incorrect comment in features.go file by [@igooch](https://redirect.github.com/igooch) in [googleforgames/agones#3944 - Update Supported Kubernetes to 1.28, 1.29, 1.30 by [@ashutosji](https://redirect.github.com/ashutosji) in [googleforgames/agones#3933 - remove ctx within the condition func by [@peterzhongyi](https://redirect.github.com/peterzhongyi) in [googleforgames/agones#3959 - Reapply "Update Supported Kubernetes to 1.28, 1.29, 1.30 ([#3933](https://redirect.github.com/googleforgames/agones/issues/3933))" ([#3](https://redirect.github.com/googleforgames/agones/issues/3)… by [@gongmax](https://redirect.github.com/gongmax) in [googleforgames/agones#3961 - change kubernetes API version to fix broken CI by [@peterzhongyi](https://redirect.github.com/peterzhongyi) in [googleforgames/agones#3962 - docs(godot): add Agones x Godot third party example by [@andresromerodev](https://redirect.github.com/andresromerodev) in [googleforgames/agones#3938 - Link Unity Netcode for Gameobjects example in documentation by [@mbychkowski](https://redirect.github.com/mbychkowski) in [googleforgames/agones#3937 - Docs: Use k8s-api-version for links by [@markmandel](https://redirect.github.com/markmandel) in [googleforgames/agones#3963 #### New Contributors - [@Orza](https://redirect.github.com/Orza) made their first contribution in [googleforgames/agones#3895 **Full Changelog**: googleforgames/agones@v1.42.0...v1.43.0 Images available with this release: - [us-docker.pkg.dev/agones-images/release/agones-controller:1.43.0](https://us-docker.pkg.dev/agones-images/release/agones-controller:1.43.0) - [us-docker.pkg.dev/agones-images/release/agones-sdk:1.43.0](https://us-docker.pkg.dev/agones-images/release/agones-sdk:1.43.0) - [us-docker.pkg.dev/agones-images/release/agones-ping:1.43.0](https://us-docker.pkg.dev/agones-images/release/agones-ping:1.43.0) - [us-docker.pkg.dev/agones-images/release/agones-allocator:1.43.0](https://us-docker.pkg.dev/agones-images/release/agones-allocator:1.43.0) - [us-docker.pkg.dev/agones-images/examples/allocation-endpoint-proxy:0.9](https://us-docker.pkg.dev/agones-images/examples/allocation-endpoint-proxy:0.9) - [us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.14](https://us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.14) - [us-docker.pkg.dev/agones-images/examples/cpp-simple-server:0.18](https://us-docker.pkg.dev/agones-images/examples/cpp-simple-server:0.18) - [us-docker.pkg.dev/agones-images/examples/crd-client:0.17](https://us-docker.pkg.dev/agones-images/examples/crd-client:0.17) - [us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.10](https://us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.10) - [us-docker.pkg.dev/agones-images/examples/rust-simple-server:0.13](https://us-docker.pkg.dev/agones-images/examples/rust-simple-server:0.13) - [us-docker.pkg.dev/agones-images/examples/simple-game-server:0.34](https://us-docker.pkg.dev/agones-images/examples/simple-game-server:0.34) - [us-docker.pkg.dev/agones-images/examples/supertuxkart-example:0.14](https://us-docker.pkg.dev/agones-images/examples/supertuxkart-example:0.14) - [us-docker.pkg.dev/agones-images/examples/unity-simple-server:0.3](https://us-docker.pkg.dev/agones-images/examples/unity-simple-server:0.3) - [us-docker.pkg.dev/agones-images/examples/xonotic-example:2.0](https://us-docker.pkg.dev/agones-images/examples/xonotic-example:2.0) Helm chart available with this release: - <a href="https://agones.dev/chart/stable/agones-1.43.0.tgz" data-proofer-ignore> <code>helm install agones agones/agones --version 1.43.0</code></a> > Make sure to add our stable helm repository using `helm repo add agones https://agones.dev/chart/stable` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate).

vicentefb marked this pull request as draft July 30, 2024 00:06

github-actions bot added kind/feature New features for Agones size/S labels Jul 30, 2024

markmandel reviewed Aug 1, 2024

View reviewed changes

github-actions bot added the size/M label Aug 6, 2024

vicentefb requested a review from markmandel August 6, 2024 18:01

gongmax reviewed Aug 7, 2024

View reviewed changes

pkg/gameserverallocations/allocator.go Outdated Show resolved Hide resolved

vicentefb marked this pull request as ready for review August 14, 2024 16:33

vicentefb requested a review from gongmax August 19, 2024 22:34

gongmax reviewed Aug 20, 2024

View reviewed changes

vicentefb force-pushed the Performance branch from 199be7d to 88052f6 Compare August 21, 2024 06:41

vicentefb requested a review from gongmax August 21, 2024 06:42

gongmax reviewed Aug 21, 2024

View reviewed changes

pkg/gameserverallocations/allocator.go Outdated Show resolved Hide resolved

site/content/en/docs/Guides/metrics.md Outdated Show resolved Hide resolved

pkg/gameserversets/metrics.go Outdated Show resolved Hide resolved

vicentefb added 4 commits August 21, 2024 22:56

metrics changes

e10ba5e

metrics changes

ded2643

error rate metric

080eb08

error rate metric nit

cddd2c8

vicentefb added 22 commits August 21, 2024 22:56

error rate metric nit nit

5ffe379

error rate metric nit nit nit

9c504b4

error rate metrics update increment

f7d0fa5

error rate metric update

84bd078

error rate update

67ab0a7

latency update

2f4fced

test

45dbcdc

test

d35703b

test

ba58c82

added metric for success rate inside the retry loop of the allocator

e5d29ae

nit

2255fbe

nit

59545bd

nit

2b2c2a9

added metric for gameserver creation duration inside the controller

1bc6804

updated metric to be a histogram and exported recordwithtags function

4139fea

lint

c61cee5

added documentation with feature shortcode

21bc0ae

nit

b5276da

nit

2d63f94

comment nit

3786a62

lint

517d0be

addressed nit comments and changed function name

69b96e6

addressed comments and updated documentation

76bd6d4

vicentefb force-pushed the Performance branch from 0315b59 to 76bd6d4 Compare August 21, 2024 23:19

gongmax approved these changes Aug 21, 2024

View reviewed changes

gongmax enabled auto-merge (squash) August 21, 2024 23:32

gongmax merged commit 1a5dc06 into googleforgames:main Aug 22, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Performance] - Added a new metric inside the allocator to track the success retry rate inside the retry loop #3927

[Performance] - Added a new metric inside the allocator to track the success retry rate inside the retry loop #3927

vicentefb commented Jul 30, 2024

vicentefb commented Jul 30, 2024

agones-bot commented Jul 30, 2024

agones-bot commented Jul 30, 2024

agones-bot commented Jul 31, 2024

markmandel Aug 1, 2024

vicentefb Aug 2, 2024

markmandel Aug 2, 2024

vicentefb Aug 6, 2024 •

edited

Loading

agones-bot commented Aug 6, 2024

agones-bot commented Aug 6, 2024

agones-bot commented Aug 6, 2024

agones-bot commented Aug 6, 2024

agones-bot commented Aug 7, 2024

agones-bot commented Aug 12, 2024

agones-bot commented Aug 12, 2024

agones-bot commented Aug 20, 2024

agones-bot commented Aug 21, 2024

agones-bot commented Aug 21, 2024

agones-bot commented Aug 22, 2024

	func recordWithTags(ctx context.Context, mutators []tag.Mutator, ms ...stats.Measurement) {
	if err := stats.RecordWithTags(ctx, mutators, ms...); err != nil {
	logger.WithError(err).Warn("error while recoding stats")
	}
	}

[Performance] - Added a new metric inside the allocator to track the success retry rate inside the retry loop #3927

[Performance] - Added a new metric inside the allocator to track the success retry rate inside the retry loop #3927

Conversation

vicentefb commented Jul 30, 2024

vicentefb commented Jul 30, 2024

agones-bot commented Jul 30, 2024

agones-bot commented Jul 30, 2024

agones-bot commented Jul 31, 2024

markmandel Aug 1, 2024

Choose a reason for hiding this comment

vicentefb Aug 2, 2024

Choose a reason for hiding this comment

markmandel Aug 2, 2024

Choose a reason for hiding this comment

vicentefb Aug 6, 2024 • edited Loading

Choose a reason for hiding this comment

agones-bot commented Aug 6, 2024

agones-bot commented Aug 6, 2024

agones-bot commented Aug 6, 2024

agones-bot commented Aug 6, 2024

agones-bot commented Aug 7, 2024

agones-bot commented Aug 12, 2024

agones-bot commented Aug 12, 2024

agones-bot commented Aug 20, 2024

agones-bot commented Aug 21, 2024

agones-bot commented Aug 21, 2024

agones-bot commented Aug 22, 2024

vicentefb Aug 6, 2024 •

edited

Loading