Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1069 automatic diff failure partly meta issue #1074

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

similato87
Copy link
Collaborator

Removed Line Numbers in Text Output & Changes Validation Bug Fix

Following the guidance provided by @ATheorell and the discussions in issue #1069, I have made the necessary updates to the text output. This includes the removal of line numbers from the print output, which aligns with the consensus for a cleaner and more user-friendly display. Additionally, I have corrected the changes validation function in improve function.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (a8b82d1) to head (5d9782b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
+ Coverage   84.13%   84.45%   +0.32%     
==========================================
  Files          26       26              
  Lines        1393     1396       +3     
==========================================
+ Hits         1172     1179       +7     
+ Misses        221      217       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akaihola
Copy link
Contributor

I can confirm that this PR fixes the problem I reported in #1073. I now get the Do you want to apply these changes? [y/N] prompt again.

@ATheorell ATheorell merged commit 7873779 into main Mar 19, 2024
6 checks passed
@similato87 similato87 deleted the 1069-automatic-diff-failure-partly-meta-issue branch March 20, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Automatic diff failure (partly meta issue)
3 participants