feat: Enable log volume endpoint by default (#12628)

grafana · Apr 16, 2024 · 397aa56 · 397aa56
1 parent 56c5dc3
commit 397aa56
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/docs/sources/shared/configuration.md b/docs/sources/shared/configuration.md
@@ -3148,7 +3148,8 @@ The `limits_config` block configures global and per-tenant limits in Loki. The v
 [max_querier_bytes_read: <int> | default = 150GB]
 
 # Enable log-volume endpoints.
-[volume_enabled: <boolean>]
+# CLI flag: -limits.volume-enabled
+[volume_enabled: <boolean> | default = true]
 
 # The maximum number of aggregated series in a log-volume response
 # CLI flag: -limits.volume-max-series

diff --git a/pkg/validation/limits.go b/pkg/validation/limits.go
@@ -385,6 +385,7 @@ func (l *Limits) RegisterFlags(f *flag.FlagSet) {
 	_ = l.MaxStructuredMetadataSize.Set(defaultMaxStructuredMetadataSize)
 	f.Var(&l.MaxStructuredMetadataSize, "limits.max-structured-metadata-size", "Maximum size accepted for structured metadata per entry. Default: 64 kb. Any log line exceeding this limit will be discarded. There is no limit when unset or set to 0.")
 	f.IntVar(&l.MaxStructuredMetadataEntriesCount, "limits.max-structured-metadata-entries-count", defaultMaxStructuredMetadataCount, "Maximum number of structured metadata entries per log line. Default: 128. Any log line exceeding this limit will be discarded. There is no limit when unset or set to 0.")
+	f.BoolVar(&l.VolumeEnabled, "limits.volume-enabled", true, "Enable log volume endpoint.")
 }
 
 // SetGlobalOTLPConfig set GlobalOTLPConfig which is used while unmarshaling per-tenant otlp config to use the default list of resource attributes picked as index labels.