Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved compression ratio histogram #1143

Merged
merged 3 commits into from
Oct 11, 2019

Conversation

joe-elliott
Copy link
Member

@joe-elliott joe-elliott commented Oct 11, 2019

What this PR does / why we need it:

  • Improves compression ratio histogram to better report actual ratios
  • Guards against divide by 0 in the ingester

Fixes #1138

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@rfratto
Copy link
Member

rfratto commented Oct 11, 2019

LGTM!

@rfratto rfratto merged commit 0f7f200 into grafana:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust loki_ingester_chunk_compression_ratio to better report compression ratio
2 participants