Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to jsoniter instead of default json package #1249

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

cyriltovena
Copy link
Contributor

I've moved mostly big object and critical path to jsoniter as it is faster than the default json package.

I'm not using the Fast config for now as it has lossy float parsing. I haven't touch one of usage like config.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! The import order is not correct though, not sure if this needs to be changed in this PR

pkg/canary/reader/reader.go Show resolved Hide resolved
@sh0rez sh0rez added the type/enhancement Something existing could be improved label Nov 30, 2019
@cyriltovena cyriltovena merged commit b34c2b0 into grafana:master Dec 2, 2019
@cyriltovena cyriltovena deleted the jsoniter branch December 2, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Something existing could be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants