Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): drone-cli #1274

Merged
merged 1 commit into from
Nov 26, 2019
Merged

chore(ci): drone-cli #1274

merged 1 commit into from
Nov 26, 2019

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Nov 16, 2019

Drone has a CLI (https://github.com/drone/drone-cli) that handles compiling the
Jsonnet to a valid drone.yml.

This is more elegant than our previous jsonnet | yq dance.

⚠️ DO NOT MERGE This depends on harness/drone-cli#163 which is not yet merged ⚠️ PR merged

Drone has a CLI (https://github.com/drone/drone-cli) that handles compiling the
Jsonnet to a valid `drone.yml`.

This is more elegant than our previous `jsonnet | yq` dance.
@sh0rez sh0rez added component/packaging type/enhancement Something existing could be improved lifecycle/upstream A change must be done to an upstream project first labels Nov 16, 2019
@sh0rez sh0rez removed the lifecycle/upstream A change must be done to an upstream project first label Nov 23, 2019
@sh0rez
Copy link
Member Author

sh0rez commented Nov 23, 2019

harness/drone-cli#163 is accepted, we can merge :D

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sh0rez sh0rez merged commit 8eced44 into grafana:master Nov 26, 2019
@sh0rez sh0rez deleted the drone-cli branch November 26, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/packaging type/enhancement Something existing could be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants