Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(regression): reverts grafana/loki#13039 to prevent use-after-free corruptions #13162

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix(regression): reverts grafana/loki#13039 to prevent use-after-free corruptions #13162

merged 1 commit into from
Jun 6, 2024

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jun 6, 2024

Temporarily reverts #13039

Looks like that PR breaks the conventions around pool reuse (to safeguard use-after-free memory corruptions) described here and here.

@owen-d owen-d requested a review from a team as a code owner June 6, 2024 19:39
@owen-d owen-d merged commit 41c5ee2 into main Jun 6, 2024
60 checks passed
@owen-d owen-d deleted the revert-13039-chaudum/allocator branch June 6, 2024 19:47
@chaudum
Copy link
Contributor

chaudum commented Jun 7, 2024

Looks like that PR breaks the conventions around pool reuse (to safeguard use-after-free memory corruptions) described here and here.

I don't think that is the case. When obtaining a BlockQuerier on the write path (here), it is instantiated with the SimpleHeapAllocator, which does not re-cycle any buffers when Put() is called (here)

chaudum added a commit that referenced this pull request Jun 7, 2024
@chaudum
Revert "fix(regression): reverts #13039 to prevent use-after-free cor…
47b9ff1 
…ruptions (#13162)"

This reverts commit 41c5ee2.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum added a commit that referenced this pull request Jun 7, 2024
@chaudum
perf: Introduce fixed size memory pool for bloom querier
093edd5 
---

Revert "fix(regression):  reverts #13039 to prevent use-after-free corruptions (#13162)"

This reverts commit 41c5ee2.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum added a commit that referenced this pull request Jun 7, 2024
@chaudum
perf: Introduce fixed size memory pool for bloom querier
9d392d2 
---

Revert "fix(regression):  reverts #13039 to prevent use-after-free corruptions (#13162)"

This reverts commit 41c5ee2.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum mentioned this pull request Jun 7, 2024
Merged
7 tasks
chaudum added a commit that referenced this pull request Jun 7, 2024
@chaudum
perf: Introduce fixed size memory pool for bloom querier
d83b060 
---

Revert "fix(regression):  reverts #13039 to prevent use-after-free corruptions (#13162)"

This reverts commit 41c5ee2.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 10, 2024
Closed
chaudum added a commit that referenced this pull request Jun 10, 2024
@chaudum
perf: Introduce fixed size memory pool for bloom querier
3692235 
---

Revert "fix(regression):  reverts #13039 to prevent use-after-free corruptions (#13162)"

This reverts commit 41c5ee2.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 17, 2024
Merged
chaudum added a commit that referenced this pull request Jun 19, 2024
@chaudum
perf: Introduce fixed size memory pool for bloom querier
ad79a80 
---

Revert "fix(regression):  reverts #13039 to prevent use-after-free corruptions (#13162)"

This reverts commit 41c5ee2.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum added a commit that referenced this pull request Jun 20, 2024
@chaudum
perf: Re-introduce fixed size memory pool for bloom querier (#13172)
4117b6c 
This PR re-introduces the fixed size memory pool that was originally introduced with #13039 but reverted with #13162
Additionally, it removes the package-global variable to store the type of allocator that should be used. Instead, the allocator type is passed during the bloom store creation.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Closed
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Open
This was referenced Jul 3, 2024
Closed
Closed
Closed
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owen-d @chaudum @slim-bean