Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes linter warning from the yacc file. #1328

Merged
merged 2 commits into from
Nov 28, 2019

Conversation

cyriltovena
Copy link
Contributor

While taking a look at cortexproject/cortex#1853 it seems that we were skipping some linters globally because of an issue with golangci-lint and the generated yacc file pkg/logql/expr.y.go.

Somehow every comment starting with //line will cause a WARN message and skip linter.

This PR fixes this issue by cleaning up the file after generation. The rest of the changes are actually hidden lint error we could not see so far.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@cyriltovena cyriltovena merged commit 27f17bc into grafana:master Nov 28, 2019
@cyriltovena cyriltovena deleted the lint-warn branch November 28, 2019 14:14
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
Include metric name, label name, number of entries and limit in cardinality errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants