Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic in ingester when not running with boltdb shipper while queriers does #2830

Conversation

sandeepsukhani
Copy link
Contributor

@sandeepsukhani sandeepsukhani commented Oct 28, 2020

What this PR does / why we need it:
When ingesters are not running boltdb-shipper, GetChunkIDs proto call returns a nil response instead of empty response which causes ingesters to panic, trying to marshal a nil value. This would happen when ingesters are not running boltdb-shipper while queriers are.

Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #2830 into master will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2830      +/-   ##
==========================================
+ Coverage   61.30%   61.33%   +0.03%     
==========================================
  Files         179      179              
  Lines       14438    14438              
==========================================
+ Hits         8851     8856       +5     
+ Misses       4780     4773       -7     
- Partials      807      809       +2     
Impacted Files Coverage Δ
pkg/ingester/ingester.go 46.27% <0.00%> (ø)
pkg/canary/comparator/comparator.go 76.36% <0.00%> (-1.82%) ⬇️
pkg/logql/evaluator.go 91.24% <0.00%> (-0.41%) ⬇️
pkg/promtail/positions/positions.go 58.51% <0.00%> (+11.70%) ⬆️

@sandeepsukhani sandeepsukhani merged commit 7f4d6d5 into grafana:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants