fluent-bit: Rename Fluent Bit plugin output name. #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents a clash with the Loki plugin now included with the Fluent Bit agent by default. The output plugin is now named `grafana-loki`. Signed-off-by: Heds Simons <heds@whaleway.net>
Codecov Report
@@ Coverage Diff @@
## master #2974 +/- ##
==========================================
- Coverage 61.84% 61.76% -0.09%
==========================================
Files 182 182
Lines 14870 14870
==========================================
- Hits 9197 9184 -13
- Misses 4824 4838 +14
+ Partials 849 848 -1
|
|
/cc @kavirajk This could helps you run two Loki output in a single fluent-bit container. |
slim-bean
pushed a commit
that referenced
this pull request
Dec 23, 2020
This prevents a clash with the Loki plugin now included with the Fluent Bit agent by default. The output plugin is now named `grafana-loki`. Signed-off-by: Heds Simons <heds@whaleway.net> (cherry picked from commit b195e94)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a clash with the Loki plugin now included with
the Fluent Bit agent by default.
The output plugin is now named
grafana-loki.Signed-off-by: Heds Simons heds@whaleway.net
What this PR does / why we need it:
Fluent Bit now ships with their version of a Loki output plugin. Unfortunately, they named it
loki, so when trying to use the Grafana Loki Fluent Bit plugin a clash occurs and Fluent Bit exits.This PR changes the name of the Loki output stage to
grafana-lokito circumvent this and allow the plugin to continue working.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Tested by building both the Fluent Bit plugin (via
make fluent-bit-plugin) and running it against the latest Fluent Bit client.Also built and tested the Fluent Bit docker image.
Both were tested against a Grafana hosted remote Loki endpoint.
Checklist