Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set helm chart appVersion while release #855

Merged
merged 1 commit into from
Aug 17, 2019

Conversation

ikeeip
Copy link
Contributor

@ikeeip ikeeip commented Aug 6, 2019

What this PR does / why we need it:

Release script tools/release_prepare.sh doesn't updates appVersion in helm charts while release. This MR fixes this.

before:

$ helm search loki
NAME            	CHART VERSION	APP VERSION	DESCRIPTION
loki/loki       	0.13.0       	0.0.1      	Loki: like Prometheus, but for logs.
loki/loki-stack 	0.14.0       	0.0.1      	Loki: like Prometheus, but for logs.
...

after:

$ helm search loki
NAME            	CHART VERSION	APP VERSION	DESCRIPTION
local/loki      	0.14.0       	v0.2.0     	Loki: like Prometheus, but for logs.
local/loki-stack	0.15.0       	v0.2.0     	Loki: like Prometheus, but for logs.
...

Which issue(s) this PR fixes:
none

Special notes for your reviewer:

I have run fixed tools/release_prepare.sh locally and this is why local/loki package shown in the example.

Checklist
not needed

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2019

CLA assistant check
All committers have signed the CLA.

@sh0rez sh0rez added component/packaging type/enhancement Something existing could be improved labels Aug 6, 2019
@sh0rez sh0rez changed the title component/packaging: set helm chart appVersion while release set helm chart appVersion while release Aug 6, 2019
@sh0rez sh0rez requested a review from slim-bean August 6, 2019 08:56
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch LGTM!

@slim-bean slim-bean merged commit 9bb6bc2 into grafana:master Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/packaging type/enhancement Something existing could be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants