Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full cirlce #997

Merged
merged 1 commit into from
Sep 9, 2019
Merged

full cirlce #997

merged 1 commit into from
Sep 9, 2019

Conversation

slim-bean
Copy link
Collaborator

No description provided.

@slim-bean slim-bean merged commit 5c99fe3 into master Sep 9, 2019
@rfratto rfratto deleted the circle branch November 1, 2019 12:10
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
…fana#997)

* Defer converting from LabelPairs to Metric until needed

Since we average hundreds of samples to a chunk, it saves a lot of
work to leave label name/value sets as the slice they come in as,
rather than converting to the map type that Prometheus uses.

They are converted on flush, to avoid changing the chunk store.

* Store labelPairs in series sorted, for faster lookup
* Extract BenchmarkMetric as re-usable fixture for tests
* Add benchmark for Ingester Push()
* Copy name/value bytes, to avoid keeping the gRPC buffer alive
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
…ush (grafana#997)"

Seeing `ValidationException` errors from DynamoDB.

This reverts commit 3e8dfbb27cfbe717511a59a8b9a6abc48bc11fc8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants