Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change to make fetch work #1787

Open
wants to merge 1 commit into
base: source
Choose a base branch
from
Open

Conversation

3willows
Copy link

@3willows 3willows commented Oct 2, 2024

Closes #

Description

Copy link

linux-foundation-easycla bot commented Oct 2, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

vercel bot commented Oct 2, 2024

@3willows is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! However, I'm not sure this is the right change:

  • Assuming you're serving the code from http://localhost:4000 this should not be needed.
  • If you're not serving the code from http://localhost:4000 then there are all sorts of additional concerns that we'd need to address, such as CORS.

Perhaps a clarifying note to state that this code must be served from your server at http://localhost:4000 would be a better solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants