Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance error message feed for missing details #4183

Open
wants to merge 4 commits into
base: opensight-ui
Choose a base branch
from

Conversation

daniele-mng
Copy link
Contributor

@daniele-mng daniele-mng commented Oct 11, 2024

What

  • When feed owner is missing, the error message is more detailed.

Why

  • Previous error message was not detailed for the user.

References

GEA-639

Checklist

  • Tests

@daniele-mng daniele-mng requested a review from a team as a code owner October 11, 2024 07:35
Copy link

github-actions bot commented Oct 11, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA d872a7e.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented Oct 11, 2024

Conventional Commits Report

Type Number
Added 3
Bug Fixes 1

🚀 Conventional commits found.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 86.23853% with 15 lines in your changes missing coverage. Please review.

Project coverage is 64.43%. Comparing base (23dc9df) to head (d872a7e).

Files with missing lines Patch % Lines
src/gmp/http/http.js 75.67% 9 Missing ⚠️
src/gmp/commands/feedstatus.js 91.66% 3 Missing ⚠️
allowedSnakeCase.cjs 0.00% 2 Missing ⚠️
src/web/authorized.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           opensight-ui    #4183      +/-   ##
================================================
+ Coverage         64.39%   64.43%   +0.03%     
================================================
  Files              1111     1111              
  Lines            103662   103755      +93     
  Branches           6466     6483      +17     
================================================
+ Hits              66755    66856     +101     
+ Misses            36767    36759       -8     
  Partials            140      140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant