Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Explicitly implement audit subobjects and add compliance_count to AuditLastReport #26

Merged

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Feb 10, 2021

What:

Why:

  • LastReport was missing compliance_count field for audits.
  • Task and Audits are different and Audits should not inherit so much from Task.

How:

Tests are still passing. New tests are also passing.

Checklist:

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #26 (438994e) into master (b586a93) will increase coverage by 0.21%.
The diff coverage is 92.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   96.84%   97.05%   +0.21%     
==========================================
  Files         122      121       -1     
  Lines        7315     7376      +61     
==========================================
+ Hits         7084     7159      +75     
+ Misses        231      217      -14     
Impacted Files Coverage Δ
selene/schema/audits/fields.py 92.22% <92.36%> (-1.12%) ⬇️
selene/schema/__init__.py 99.23% <0.00%> (-0.01%) ⬇️
selene/schema/nvts/mutations.py
selene/schema/reports/fields.py 91.30% <0.00%> (+0.43%) ⬆️
selene/schema/cves/fields.py 85.52% <0.00%> (+12.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b586a93...bff2bdf. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review February 10, 2021 14:30
@saberlynx saberlynx requested a review from a team February 10, 2021 14:30
bjoernricks
bjoernricks previously approved these changes Feb 11, 2021
@y0urself y0urself merged commit b367d51 into greenbone:master Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants