Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Support credential download and add fields to Credential #66

Merged
merged 4 commits into from
Mar 10, 2021

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Mar 9, 2021

What:

Support argument credential_format in single Credential query and include fields in the Credential entity to support download of credentialPackage, publicKey and certificate formats.

Why:

In GSA it is possible to download these formats and without the credential_format argument, this does not work.

How:

Unit tests.

Checklist:

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #66 (ffa67ee) into master (aff4cce) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   97.89%   97.90%           
=======================================
  Files         122      122           
  Lines        7617     7630   +13     
=======================================
+ Hits         7457     7470   +13     
  Misses        160      160           
Impacted Files Coverage Δ
selene/schema/credentials/fields.py 96.42% <100.00%> (+0.97%) ⬆️
selene/schema/credentials/queries.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aff4cce...ffa67ee. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review March 10, 2021 11:10
@saberlynx saberlynx requested a review from a team March 10, 2021 11:10
@y0urself y0urself merged commit b9ebd8c into greenbone:master Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants