-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Feed is loaded many times in readis after openvasd restart #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnicola
force-pushed
the
rs-fix-feed-upload
branch
from
July 26, 2024 18:07
398fcc4
to
1261b4e
Compare
github-actions
bot
added
patch_release
creates a patch release
and removed
patch_release
creates a patch release
labels
Jul 26, 2024
jjnicola
force-pushed
the
rs-fix-feed-upload
branch
from
July 29, 2024 08:54
1261b4e
to
e6c0126
Compare
github-actions
bot
added
patch_release
creates a patch release
and removed
patch_release
creates a patch release
labels
Jul 29, 2024
Tehforsch
previously approved these changes
Jul 30, 2024
jjnicola
force-pushed
the
rs-fix-feed-upload
branch
from
August 2, 2024 15:09
e6c0126
to
74eb516
Compare
github-actions
bot
added
patch_release
creates a patch release
and removed
patch_release
creates a patch release
labels
Aug 2, 2024
jjnicola
force-pushed
the
rs-fix-feed-upload
branch
from
August 5, 2024 09:21
74eb516
to
8aa88a7
Compare
github-actions
bot
added
patch_release
creates a patch release
and removed
patch_release
creates a patch release
labels
Aug 5, 2024
Check if the current version is already in the cache before uploading. Also remove the old entries before uploading, if the entry is present to avoid the amount if items inside keys (duplication). Jira: SC-1122
jjnicola
force-pushed
the
rs-fix-feed-upload
branch
from
August 7, 2024 15:46
8aa88a7
to
043403b
Compare
github-actions
bot
added
patch_release
creates a patch release
and removed
patch_release
creates a patch release
labels
Aug 7, 2024
2 tasks
Tehforsch
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Check if the current version is already in the cache before uploading. Also remove the old entries before uploading, if the entry is present to avoid the amount if items inside keys (duplication).
Jira: SC-1122
Why:
After reloading openvasd, the feed is completely uploaded without deleting the present entries which increases the memory usages.
Also, If the feed does not changed (same feed version), the feed shouldn't be uploaded.
How:
restart openvasd many times and check the redis cache
Checklist: