-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: nasl built regex library, regex nasl functions and tests. #1704
Conversation
Do not replace raw char new line (0x0A) for String type, but for Data type. This is how C implementation behaves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the comments, I think we should consider changing the FromNaslValue
impl for String to make a lot of the changes to nasl-builtin-string unnecessary.
I added SC-1148 to address the string conversion behavior and resolved the corresponding conversations. All other suggestions still apply. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - just a few minor comments.
I think we can significantly clean up the string implementations but I'll defer this until we decided on SC-1148.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What:
Add nasl built regex library, regex nasl functions and tests
Jira: SC-1143
Jira: SC-1144
Why:
How:
Since the output of display() differs among C and Rust implementations, use the following script for debugging with
gdb
andrust-gdb
respectively. Also unit test where added/updated.Checklist: