estats: remove dependency on testing package #7579
Merged
+26
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7579 +/- ##
==========================================
- Coverage 81.73% 81.73% -0.01%
==========================================
Files 361 361
Lines 27809 27808 -1
==========================================
- Hits 22730 22729 -1
+ Misses 3869 3868 -1
- Partials 1210 1211 +1
|
dfawley
reviewed
Sep 3, 2024
| func snapshotMetricsRegistryForTesting(t *testing.T) { | ||
| // registry. Returns a cleanup function that sets the metrics registry to its | ||
| // original state. | ||
| func snapshotMetricsRegistryForTesting() func() { |
There was a problem hiding this comment.
If this isn't exported anyway, then can't we simply move it into an _test.go file?
There was a problem hiding this comment.
We can't do that since internal.SnapshotMetricRegistryForTesting is set to this unexported function (in an init function) and the variable in internal package is used by other tests and therefore needs to be set.
dfawley
approved these changes
Sep 3, 2024
purnesh42H
pushed a commit
to purnesh42H/grpc-go
that referenced
this pull request
Sep 11, 2024
purnesh42H
pushed a commit
to purnesh42H/grpc-go
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7568
RELEASE NOTES:
testingpackage