Improve module load error message when the directory does not exist #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjin
reviewed
Feb 8, 2018
| } catch (readDirError) { | ||
| let message = `The gRPC binary module was not installed | ||
| This may be fixed by running "npm rebuild" | ||
| Original error: ${e.message}`; |
There was a problem hiding this comment.
Should this be readDirError.message? (And same with e.code below)
There was a problem hiding this comment.
Also, it seems like the first two lines can fit together on a single line.
There was a problem hiding this comment.
No, it's supposed to be e.message and e.code, because e is the original error that we are trying to communicate.
Also, I just made the structure of the error message match the other error. I could merge those lines, though.
There was a problem hiding this comment.
OK, I merged the lines.
kjin
approved these changes
Feb 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of times, e.g. in grpc/grpc#6435, people have reported errors indicating that the binary module directory doesn't exist at all, which isn't communicated well. This fixes that.