Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add warning alert for H2 database on data initialization page #6564

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 1, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.19.0

What this PR does / why we need it:

将 H2 数据库使用警告放置在数据初始化页面,之前放在初始化表单页面无法正确判断,因为没有登录,无法调用 /actuator/info 接口获取数据库数据。

image

Fixes #6561

Special notes for your reviewer:

需要使用此 PR 测试使用 H2 数据库全新安装,观察是否在数据初始化页面有 H2 数据库的使用提示。

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note-none Denotes a PR that doesn't merit a release note. labels Sep 1, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.0 milestone Sep 1, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Sep 1, 2024
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.03%. Comparing base (6cd8dc8) to head (0c703de).
Report is 44 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6564      +/-   ##
============================================
- Coverage     58.18%   58.03%   -0.15%     
- Complexity     3774     3915     +141     
============================================
  Files           651      670      +19     
  Lines         22125    22954     +829     
  Branches       1538     1573      +35     
============================================
+ Hits          12873    13322     +449     
- Misses         8641     9015     +374     
- Partials        611      617       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ui/src/locales/zh-CN.yaml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 1, 2024

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2024
Copy link

f2c-ci-robot bot commented Sep 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit f674732 into halo-dev:main Sep 1, 2024
8 checks passed
@ruibaby ruibaby deleted the refactor/h2-warning-alert branch September 1, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

初始化页面无法正常判断是否使用了 H2 数据库
2 participants